Skip to content

Commit

Permalink
Restore the defaults for targetPort when not explicitly set (#26)
Browse files Browse the repository at this point in the history
The original intent with having separate `httpPorts` and `httpsPorts` was to be able to specify multiple ports of each kind, mapped to the `http` and `https` ports, respectively, on the haproxy-ingress pod. When the ability to set the `targetPort` was added by 00ce053, backwards compatibility was broken by removing the defaults.

Fixes #25
  • Loading branch information
mhyllander authored Jun 9, 2021
1 parent 2055d42 commit 74f4a18
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions haproxy-ingress/templates/controller-service.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@ spec:
- name: "http-{{ .port }}"
port: {{ .port }}
protocol: TCP
targetPort: {{ .targetPort }}
targetPort: {{ .targetPort | default "http" }}
{{- if (not (empty .nodePort)) }}
nodePort: {{ .nodePort }}
{{- end }}
Expand All @@ -61,7 +61,7 @@ spec:
- name: "https-{{ .port }}"
port: {{ .port }}
protocol: TCP
targetPort: {{ .targetPort }}
targetPort: {{ .targetPort | default "https" }}
{{- if (not (empty .nodePort)) }}
nodePort: {{ .nodePort }}
{{- end }}
Expand Down

0 comments on commit 74f4a18

Please sign in to comment.