Fixed time out issue #3436
Fixed time out issue #3436
Conversation
- Resolved issue with redundant timeout. - Updated to use promises. - added many new tests
- added many new tests
Added sinon to devDependencies. It is used in mail_from.is_resolvable tests.
Removed redundant time out
|
After this change, what happens when a DNS query takes 31+ seconds to resolve? My memory thinks that it used to be something unpleasant, which was why that 29s timeout was added. |
|
I'll work on it over the next few days. |
|
I'm confident that the timeout issues have been resolved. I've also added some timeout tests. |
Added tests for DNS resolver timeouts
Refactored to better handle promises and timeouts
|
Now that this PR is complete ... 😬, can I make another ask? (I'd just do it, except that then the commits would be tagged with my name, and I'd prefer you get the credit). I just created https://github.com/haraka/haraka-plugin-mail_from.is_resolvable. You should be able to clone the repo, hop inside, and something like this should Just Work[TM]: cd haraka-plugin-mail_from.is_resolvable
npm install --save-dev sinon
cp ~git/haraka/Haraka/plugin/mail_from.is_resolvable.js index.js
cp ~git/haraka/Haraka/test/plugins/mail_from.is_resolvable.js test/index.js
npm install
npm testIf the tests need something more feature full than node's built-in test runner, you can switch it out for mocha (test with |
Fixes #
Changes proposed in this pull request:
Checklist: