Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable CanFD support in "serial" interface #1566

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Enable CanFD support in "serial" interface
* Remove (DLC <= 8) limitation
jacky309 authored Apr 13, 2023

Verified

This commit was signed with the committer’s verified signature.
KommuSoft willeM_ Van Onsem
commit e545ed53c07ee05f95c28c7d55ce3a0296458491
2 changes: 0 additions & 2 deletions can/interfaces/serial/serial_can.py
Original file line number Diff line number Diff line change
@@ -179,8 +179,6 @@ def _recv_internal(
s = self._ser.read(4)
timestamp = struct.unpack("<I", s)[0]
dlc = ord(self._ser.read())
if dlc > 8:
raise ValueError("received DLC may not exceed 8 bytes")

s = self._ser.read(4)
arbitration_id = struct.unpack("<I", s)[0]