Open
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #995 +/- ##
===========================================
- Coverage 70.38% 69.45% -0.93%
===========================================
Files 70 76 +6
Lines 6841 7403 +562
===========================================
+ Hits 4815 5142 +327
- Misses 2026 2261 +235 |
hardbyte
reviewed
Mar 25, 2021
Owner
hardbyte
left a comment
hardbyte
left a comment
There was a problem hiding this comment.
It would be good to connect the socketcan CyclicSendTask too if you're up for it?
A new test in simplecyclic_test.py would be appreciated too
| messages: Union[Sequence[Message], Message], | ||
| period: float, | ||
| duration: Optional[float], | ||
| count: Optional[int], |
Owner
There was a problem hiding this comment.
Suggested change
| count: Optional[int], | |
| count: Optional[int] = None, |
| self.stopped = True | ||
| self.thread = None | ||
| self.end_time = time.perf_counter() + duration if duration else None | ||
| self.end_count = count if count else None |
Owner
There was a problem hiding this comment.
Suggested change
| self.end_count = count if count else None | |
| self.end_count = count |
Contributor
Author
|
Sure will modify your suggestions and try to add a test aswell. |
Collaborator
|
@zorce You can also just click on "Commit Suggestion" right from the GUI to apply the changes by hardbyte. |
Collaborator
|
@zorce Some conflicts have popped up by now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add possibility to send periodic messages with a stop count as a criteria to facilitate one of sequences.
Closes #992