Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: [FFM-11103]: Replace btoa usage with custom base64 encoding to handle non-ascii characters #124

Merged
merged 1 commit into from
Apr 9, 2024
Merged

fix: [FFM-11103]: Replace btoa usage with custom base64 encoding to handle non-ascii characters #124

merged 1 commit into from
Apr 9, 2024

Conversation

knagurski
Copy link
Contributor

@knagurski knagurski commented Apr 9, 2024 •
edited
Loading

This PR replaces the usage of btoa with a custom base64 encoding. btoa does not handle non-ascii characters.

Fixes: #121

@knagurski knagurski self-assigned this Apr 9, 2024
erdirowlands
erdirowlands approved these changes Apr 9, 2024
View reviewed changes
Copy link
Contributor

@erdirowlands erdirowlands left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@knagurski knagurski merged commit 53da920 into main Apr 9, 2024
3 checks passed
@knagurski knagurski deleted the FFM-11103-encode-with-unicode branch April 9, 2024 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@erdirowlands erdirowlands erdirowlands approved these changes

Assignees

@knagurski knagurski

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

SDK Doesn't work for Japan characters/letters in Target
2 participants
@knagurski @erdirowlands