FFM-10924 Streaming disconnect log level changes #125
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ing after every attempts
andybharness
approved these changes
Apr 15, 2024
knagurski
reviewed
Apr 15, 2024
Co-authored-by: Kevin Nagurski <Kevin.nagurski@harness.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
debuginstead oferrorerrorwill be logged if reconnection is still being attempted after every5, 10, 15...attemptsWhy
We expect occasional stream disconnects/timeouts and the SDK will "self-heal" by reconnecting. Logging these as errors in the first instance is misleading and can cause users to be concerned unjustifiably.
Testing
Manual - using proxy tool to simulate disconnects.