[FFM-9621] - Avoid sending empty metric payloads (#89)

* [FFM-9621] - Avoid sending empty metric payloads What Adds a check to make sure metrics data is not empty before sending it. Why We're seeing empty metrics payloads arriving at the BE we should avoid wasting network bandwidth. Testing Manual Co-authored-by: Kevin Nagurski <Kevin.nagurski@harness.io>
harness · Oct 17, 2023 · b8c7f8a · b8c7f8a
1 parent d0019e1
commit b8c7f8a
Show file tree

Hide file tree

Showing 4 changed files with 6 additions and 5 deletions.
diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "@harnessio/ff-nodejs-server-sdk",
-  "version": "1.3.4",
+  "version": "1.3.5",
   "description": "Feature flags SDK for NodeJS environments",
   "main": "dist/cjs/index.js",
   "module": "dist/esm/index.mjs",

diff --git a/src/metrics.ts b/src/metrics.ts
@@ -188,7 +188,8 @@ export const MetricsProcessor = (
     }
 
     const metrics: Metrics = _summarize();
-    if (metrics) {
+
+    if (metrics && metrics.metricsData.length && metrics.targetData.length) {
       log.debug('Start sending metrics data');
       api
         .postMetrics(environment, cluster, metrics)

diff --git a/src/version.ts b/src/version.ts
@@ -1 +1 @@
-export const VERSION = "1.3.4";
+export const VERSION = "1.3.5";