Clarifications to Device specification and consistent terminology #197
+103
−101
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
|
@bruno-f-cruz @Poofjunior I am trying to close here all outstanding issues with the device specification that you encountered when implementing the core.pico. The currently outstanding are: |
This is an alternative to explicitly specifying the length in the title while maintaining good readability in document TOC.
glopesdev
force-pushed
the
dev/device-terminology
branch
from
e15cac0 to
72652eb
Compare
bruno-f-cruz
requested changes
Nov 18, 2025
Member
bruno-f-cruz
left a comment
bruno-f-cruz
left a comment
There was a problem hiding this comment.
One small comment that we should address before making a 2.0 release, but otherwise lgtm
glopesdev
force-pushed
the
dev/device-terminology
branch
from
13953c3 to
fc55475
Compare
bruno-f-cruz
requested changes
Nov 22, 2025
Member
bruno-f-cruz
left a comment
bruno-f-cruz
left a comment
There was a problem hiding this comment.
One last pass, and otherwise we can merge.
bruno-f-cruz
approved these changes
Nov 27, 2025
glopesdev
force-pushed
the
dev/device-terminology
branch
from
1592658 to
64366fe
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To ensure terminology remains consistent with the binary protocol specification, we replace "host" with "Controller" and standardize capitalization as required.
Outstanding clarifications to the device specification have also been included, some of them recovered from previously closed PRs which were lost during repository reorganization, e.g. #6.
Fixes #177
Fixes #47
Fixes #5
Fixes #4