Improve PWA config for better browser support #70
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #56 Update PWA configuration and service worker registration to improve robustness and compatibility with mobile web browsers. * **Manifest Configuration:** - Add `"scope": "/"` to define the navigation scope. - Add `"description": "A text display app"`. - Add `"related_applications": []` to specify related applications. * **Service Worker Registration:** - Update the service worker registration to use `/sw.js` instead of `/service-worker.js`. * **InstallPWA Component:** - Add a check for `navigator.standalone` to detect if the app is already installed on iOS. - Add a check for `window.matchMedia('(display-mode: standalone)').matches` to detect if the app is already installed on Android. * **WelcomeModal Component:** - Add a check for `navigator.standalone` to detect if the app is already installed on iOS. - Add a check for `window.matchMedia('(display-mode: standalone)').matches` to detect if the app is already installed on Android. * **Workbox Configuration:** - Update the `swDest` to `dist/sw.js` instead of `dist/service-worker.js`. --- For more details, open the [Copilot Workspace session](https://copilot-workspace.githubnext.com/harperreed/orbiting/issues/56?shareId=XXXX-XXXX-XXXX-XXXX).
Deploying orbiting with
|
| Latest commit: |
def26ce
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://f74e7c4d.orbiting.pages.dev |
| Branch Preview URL: | https://improve-pwa-config.orbiting.pages.dev |
|
Warning Rate limit exceeded@harperreed has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 21 minutes and 5 seconds before requesting another review. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. 📒 Files selected for processing (5)
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
✅ Deploy Preview for orbit-ing ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #56
Update PWA configuration and service worker registration to improve robustness and compatibility with mobile web browsers.
Manifest Configuration:
"scope": "/"to define the navigation scope."description": "A text display app"."related_applications": []to specify related applications.Service Worker Registration:
/sw.jsinstead of/service-worker.js.InstallPWA Component:
navigator.standaloneto detect if the app is already installed on iOS.window.matchMedia('(display-mode: standalone)').matchesto detect if the app is already installed on Android.WelcomeModal Component:
navigator.standaloneto detect if the app is already installed on iOS.window.matchMedia('(display-mode: standalone)').matchesto detect if the app is already installed on Android.Workbox Configuration:
swDesttodist/sw.jsinstead ofdist/service-worker.js.For more details, open the Copilot Workspace session.