Skip to content

Commit

Permalink
update sonar workflow - cleanup
Browse files Browse the repository at this point in the history
  • Loading branch information
harrel56 committed Sep 11, 2023
1 parent fb8433c commit 6fb01c6
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 53 deletions.
34 changes: 0 additions & 34 deletions .github/workflows/build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -9,40 +9,6 @@ jobs:
tests:
uses: ./.github/workflows/tests.yml

# sonar-cloud:
# if: '!github.event.pull_request.head.repo.fork'
# runs-on: ubuntu-latest
# needs: tests
#
# steps:
# - name: Git checkout
# uses: actions/checkout@v3
# with:
# fetch-depth: 0
#
# - uses: actions/download-artifact@v3
# with:
# name: report-output
# path: build/reports
#
# - name: Setup java
# uses: actions/setup-java@v3
# with:
# # Not using variables to allow running from forks
# distribution: corretto
# java-version: 17
#
# - name: Setup Gradle
# uses: gradle/gradle-build-action@v2
# with:
# gradle-version: wrapper
#
# - name: SonarCloud analyze
# env:
# GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
# SONAR_TOKEN: ${{ secrets.SONAR_TOKEN }}
# run: ./gradlew sonar --info

deploy-gh-pages:
if: github.ref == 'refs/heads/master'
runs-on: ubuntu-latest
Expand Down
20 changes: 1 addition & 19 deletions .github/workflows/sonar.yml
Original file line number Diff line number Diff line change
Expand Up @@ -42,22 +42,4 @@ jobs:
-Dsonar.scm.revision=${{ github.event.workflow_run.head_sha }} \
-Dsonar.pullrequest.key=${{ github.event.workflow_run.pull_requests[0].number }} \
-Dsonar.pullrequest.branch=${{ github.event.workflow_run.pull_requests[0].head.ref }} \
-Dsonar.pullrequest.base=${{ github.event.workflow_run.pull_requests[0].base.ref }} \
# - name: SonarCloud Scan
# uses: sonarsource/sonarcloud-github-action@master
# env:
# GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
# SONAR_TOKEN: ${{ secrets.SONAR_TOKEN }}
# with:
# args: >
# -Dsonar.projectKey=harrel56_json-schema
# -Dsonar.organization=harrel56
# -Dsonar.host.url=https://sonarcloud.io
# -Dsonar.java.source=8
# -Dsonar.java.target=8
#
# -Dsonar.scm.revision=${{ github.event.workflow_run.head_sha }}
# -Dsonar.pullrequest.key=${{ github.event.workflow_run.pull_requests[0].number }}
# -Dsonar.pullrequest.branch=${{ github.event.workflow_run.pull_requests[0].head.ref }}
# -Dsonar.pullrequest.base=${{ github.event.workflow_run.pull_requests[0].base.ref }}
-Dsonar.pullrequest.base=${{ github.event.workflow_run.pull_requests[0].base.ref }} \

0 comments on commit 6fb01c6

Please sign in to comment.