let's allow empty fragments for more compatibility

harrel56 · Oct 13, 2023 · f138725 · f138725
1 parent 4a5acc4
commit f138725
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 6 deletions.
diff --git a/src/main/java/dev/harrel/jsonschema/Validator.java b/src/main/java/dev/harrel/jsonschema/Validator.java
@@ -140,8 +140,8 @@ public Result validate(URI schemaUri, JsonNode instanceNode) {
     }
 
     private Schema getRootSchema(URI uri) {
-        if (uri.getFragment() != null) {
-            throw new IllegalArgumentException(String.format("Root schema [%s] cannot contain fragments", uri));
+        if (uri.getFragment() != null && !uri.getFragment().isEmpty()) {
+            throw new IllegalArgumentException(String.format("Root schema [%s] cannot contain non-empty fragments", uri));
         }
         return OptionalUtil.firstPresent(
                         () -> Optional.ofNullable(schemaRegistry.get(uri.toString())),

diff --git a/src/test/java/dev/harrel/jsonschema/ValidatorTest.java b/src/test/java/dev/harrel/jsonschema/ValidatorTest.java
@@ -36,16 +36,16 @@ void failsForUriWithNonEmptyFragments() {
         URI uri = URI.create("https://test.com/x#/$def/x");
         assertThatThrownBy(() -> validator.validate(uri, "{}"))
                 .isInstanceOf(IllegalArgumentException.class)
-                .hasMessage("Root schema [https://test.com/x#/$def/x] cannot contain fragments");
+                .hasMessage("Root schema [https://test.com/x#/$def/x] cannot contain non-empty fragments");
     }
 
     @Test
-    void failsForUriWithEmptyFragments() {
+    void registersUriWithEmptyFragments() {
         Validator validator = new ValidatorFactory().createValidator();
         URI uri = URI.create("https://test.com/x#");
         assertThatThrownBy(() -> validator.validate(uri, "{}"))
-                .isInstanceOf(IllegalArgumentException.class)
-                .hasMessage("Root schema [https://test.com/x#] cannot contain fragments");
+                .isInstanceOf(SchemaNotFoundException.class)
+                .hasMessage("Couldn't find schema with uri [https://test.com/x#]");
     }
 
     @Test