-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Returning error messages from applicators #52
Returning error messages from applicators #52
Conversation
BTW thanks for the willingness to contribute :) Let me know if you want to just take care of
|
I can take care of all of them but as I am not closely familiar with all of the specification, I only handled Let me know what you think about current proposal and if there is any other applicator I should take care of :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks really good - left a few comments, mainly error messages nitpicks. Still not 100% about the suggestions but I would at least try to be more consistent
As for the failing workflows - I think I'll just test it out locally and merge. I'll try to fix it later on, so contribution would be smoother. |
Yeah, and I think the scope for now is fine. Gonna take care of whatever is left later on. Hopefully tomorrow all the changes could be released |
Thanks for the comments. I completely agree with your suggestions and have updated it accordingly |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good - appreciate your help :) gonna merge now
Work on #51 issue