Skip to content
This repository was archived by the owner on Jun 4, 2025. It is now read-only.

Allow read-only source directory #242

Merged
merged 1 commit into from
Aug 31, 2020
Merged

Allow read-only source directory #242

merged 1 commit into from
Aug 31, 2020

Conversation

tvogels01
Copy link
Contributor

@tvogels01 tvogels01 commented Aug 28, 2020

The entrypoint of the Docker image is vulnerable right now to the failing of python setup.py develop. Though that step is necessary when the source is mounted and users expect to image to reflect the state of the git repo, it's also preventing debugging any issues that might come up. So this version of the entrypoint allows a failure of python setup.py develop and gives just a warning instead of blocking the start.
See issue #237

@tvogels01 tvogels01 marked this pull request as draft August 28, 2020 18:18
@tvogels01 tvogels01 force-pushed the ignore-read-only-source branch from 472d997 to cee8d63 Compare August 28, 2020 18:20
@tvogels01 tvogels01 marked this pull request as ready for review August 28, 2020 18:21
Copy link
Contributor

@soumyadsanyal soumyadsanyal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@tvogels01 tvogels01 merged commit a8536bf into next Aug 31, 2020
@tvogels01 tvogels01 deleted the ignore-read-only-source branch August 31, 2020 21:50
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants