[Draft]: New UI and 4 finger App navigation vertical motion gestures #107
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This doesn't affect fullscreen mode, as in fullscreen mode panel is visible, but panel's parent is hidden. Fixes harshadgavali#5
This avoids glitch where widget containing window's content is shown above Tilepreview for very short duration, without any animation
This change makes touchscreen gesture behave as default
Merge forward/backward gesture to main branch and updates prefs to libadwaita
This is to avoid waiting for bindings to be available on npmjs
This makes both window switching and forwardBack gestures available
V22: Add close tab/window gesture and make forwardBack a hold-swipe gesture
This fixes issue when confirmPinch was not called, so tracker remains in pending-ack state
…sture This allows cyclic overview navigation as well as gnome-style navigation. It also adds option for only desktop<->windowPicker transitions
…states overviewRoundTrip: Add option to set navigation states for overview gesture
Merge upstream
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey @harshadgavali,
This is a draft PR and requires your help (and possible review). Follow up from PR #98.
Currently, the changes I have made require the user to select Extension (functionality) the user intends to use. So something like (visualize in your mind) or check ui file for gestures:
Swipe Gestures:
Three Finger gestures:
Four Finger gestures:
Apart from that I also moved swipe gestures src code files into their dedicated folder resonating with pinch gesture and tracker files.
Main Modification are done to
extension.tscreating a new function that set the sub-extension and gesture using a new ClassSwipeGestureToExtensionMappergiven the gesture info (n_fingers, horizontal/vertical & natural scroll in case of app navigation). This class makes sure that two gestures don't get mapped to the same extension.The problem is, here on this line the extension can be
undefinedwhich we can't push to_extensions. So that meansifcondition inget_extensionfunction's switch condition, we need to generate error and throw Dialog box informing user two gestures can't be set for one functionality OR If you have some better idea.OR we can dynamically update the model for dropdown menus as the options get selected