feat: get node name from guest agent

[FrankYang0529]

harvester/harvester#4947

Test steps

1. Create a harvester with feat(rbac): add guestosinfo to harvesterhci.io:cloudprovider harvester#5019.
2. Create VMImage and VM Network.
3. Import the harvester to a Rancher cluster.
4. Use harvester kubeconfig to run deploy/generate_addon.sh. The cluster_name is guest cluster name which we will create later. The namespace is guest cluster VM namespace.

./deploy/generate_addon <cluster_name> <namespace>

5. Set a RKE2 with External cloud provider.

6. Copy write_files from the step 4 to User Data. Also, setting a hostname.

7. Create the RKE2 cluster and wait for message waiting for cluster agent to connect.

8. Use ssh to login the VM and install helm.
9. In the VM, set kubeconfig.

sudo chmod 666 /etc/rancher/rke2/rke2.yaml
export KUBECONFIG=/etc/rancher/rke2/rke2.yaml

10. In the VM, clone the harvester charts and install harvester-cloud-provider.

git clone https://github.com/harvester/charts
cd charts/charts/harvester-cloud-provider/
helm install harvester-cloud-provider . --namespace kube-system \
  --set image.repository=frankyang/harvester-cloud-provider \
  --set image.tag=447fef20-amd64 \
  --set global.cattle.clusterName=<cluster_name>

11. Check the RKE2 cluster can be ready.

[w13915984028]

The original method was using vmClient.Get to get data from remote instead of from cache; now the getVM is checking data from sync.Map, it will have such race:
when the sync.Map is not synced fully in OnVmiChanged; the InstanceExists will not work as expected.

[FrankYang0529]

Good catch. Reverted vmCache/vmiCache to vmClient/vmiClient. Thanks.

[w13915984028]

Another question about the map, please double check, thanks.

[w13915984028]

The vmi.Namespace is not stored in the map, if VMs from different namespace have same name, will them overwrite each other?

[FrankYang0529]

I think the better way is to drop events from other namespaces because the cloud provider is running in the guest cluster. It only needs to care VMI in that namespace. We can get the namespace like instance manager. WDYT?

cloud-provider-harvester/pkg/cloud-controller-manager/ccm.go

Lines 85 to 89 in 9daecd1

	cp.instances = &instanceManager{
	vmClient: cp.kubevirtFactory.Kubevirt().V1().VirtualMachine(),
	vmiClient: cp.kubevirtFactory.Kubevirt().V1().VirtualMachineInstance(),
	namespace: namespace,
	}

[w13915984028]

It is reasonable to drop other namespaces.

[w13915984028]

LGTM, thanks.

[bk201]

lgtm.
if the change is not compatible with Harvester v1.2.x, be sure to bump the minor version when doing a new tag. (like from v0.2.0 -> v0.3.0).

[FrankYang0529]

lgtm. if the change is not compatible with Harvester v1.2.x, be sure to bump the minor version when doing a new tag. (like from v0.2.0 -> v0.3.0).

Hi @w13915984028, I think this is not a breaking change, so I will create a new tag v0.2.1.