Skip to content

Commit

Permalink
feat: Add Tech Preview tag to LH V2 data engine setting
Browse files Browse the repository at this point in the history
Signed-off-by: Tim Serong <tserong@suse.com>
Co-authored-by: Andy Lee <andy.lee@suse.com>
(cherry picked from commit 9a523c4)
  • Loading branch information
tserong authored and mergify[bot] committed Aug 30, 2024
1 parent 6e29445 commit 487f0fc
Show file tree
Hide file tree
Showing 3 changed files with 14 additions and 2 deletions.
11 changes: 11 additions & 0 deletions pkg/harvester/components/SettingList.vue
Original file line number Diff line number Diff line change
Expand Up @@ -112,6 +112,9 @@ export default {
<span v-if="setting.customized" class="modified">
Modified
</span>
<span v-if="setting.technicalPreview" v-clean-tooltip="t('advancedSettings.technicalPreview')" class="technical-preview">
Technical Preview
</span>
</h1>
<h2 v-clean-html="t(setting.description, {}, true)">
</h2>
Expand Down Expand Up @@ -200,4 +203,12 @@ export default {
padding: 2px 10px;
font-size: 12px;
}
.technical-preview {
margin-left: 10px;
border: 1px solid var(--warning);
border-radius: 5px;
padding: 2px 10px;
font-size: 12px;
}
</style>
2 changes: 1 addition & 1 deletion pkg/harvester/config/settings.js
Original file line number Diff line number Diff line change
Expand Up @@ -84,7 +84,7 @@ export const HCI_ALLOWED_SETTINGS = {
kind: 'json', from: 'import', canReset: true
},
[HCI_SETTING.KUBECONFIG_DEFAULT_TOKEN_TTL_MINUTES]: {},
[HCI_SETTING.LONGHORN_V2_DATA_ENGINE_ENABLED]: { kind: 'boolean' },
[HCI_SETTING.LONGHORN_V2_DATA_ENGINE_ENABLED]: { kind: 'boolean', technicalPreview: true },
};

export const HCI_SINGLE_CLUSTER_ALLOWED_SETTING = {
Expand Down
3 changes: 2 additions & 1 deletion pkg/harvester/l10n/en-us.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -1339,6 +1339,7 @@ harvester:
placeholder: 'topology.kubernetes.io/zone'

advancedSettings:
technicalPreview: 'Technical Previews allow users to test and evaluate early-access functionality prior to official supported releases'
descriptions:
'harv-vlan': Default Network Interface name of the VLAN network.
'harv-backup-target': Custom backup target to store VM backups.
Expand Down Expand Up @@ -1370,7 +1371,7 @@ advancedSettings:
'harv-ntp-servers': Configure NTP server. You can configure multiple IPv4 addresses or host addresses.
'harv-auto-rotate-rke2-certs': The certificate rotation mechanism relies on Rancher. Harvester will automatically update certificates generation to trigger rotation.
'harv-kubeconfig-default-token-ttl-minutes': 'TTL (in minutes) applied on Harvester admin kubeconfig files. Default is 0, which means to never expire.'
'harv-longhorn-v2-data-engine-enabled': 'Enable the Longhorn V2 data engine. Default is false. <ul><li>Changing this setting will restart RKE2 on all nodes. This will not affect running VM workloads.</li><li>If you see "not enough hugepages-2Mi capacity" errors when enabling this setting, wait a minute for the error to clear. If the error remains, reboot the affected node.</li><li>WARNING: THIS IS A PREVIEW FEATURE</li></ul>'
'harv-longhorn-v2-data-engine-enabled': 'Enable the Longhorn V2 data engine. Default is false. <ul><li>Changing this setting will restart RKE2 on all nodes. This will not affect running VM workloads.</li><li>If you see "not enough hugepages-2Mi capacity" errors when enabling this setting, wait a minute for the error to clear. If the error remains, reboot the affected node.</li></ul>'

typeLabel:
kubevirt.io.virtualmachine: |-
Expand Down

0 comments on commit 487f0fc

Please sign in to comment.