Reserved storage size in the dashboard isn't useful #1105
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
votdev
force-pushed
the
issue_6362_calc_reserved_storage
branch
3 times, most recently
from
10ffffb
to
008d334
Compare
... display allocated/scheduled storage instead. Relates to: harvester/harvester#6362 Signed-off-by: Volker Theile <vtheile@suse.com>
votdev
force-pushed
the
issue_6362_calc_reserved_storage
branch
from
008d334
to
bc0a671
Compare
a110605
approved these changes
Aug 23, 2024
|
I'm open to this. If we manage to backport this before the release, we can consult the QA to use an external ui source for validation (if there is no 1.3.2-rc3) |
tserong
approved these changes
Aug 23, 2024
a110605
added
the
Require backport v1.3
|
Hi @votdev, since v1.3.2 is released. We are good to merge and backport to |
|
1.3.2 is out. It looks like this didn't make it. Can we put it in 1.4 now before it passes? |
This was referenced Sep 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The displayed storage statistics in the
DashboardandHostspage were incorrect. The calculation was incorrect and has been adapted to how it is done in Longhorn.Related Issue #
harvester/harvester#6362
Occurred changes and/or fixed issues
ReservedtoAllocated.HardwareResourceGaugeto be able to customize the titles.Technical notes summary
The most important change was the calculation of the
totalstorage which is done based on the formula((maximum - reserved) * storageOverProvisioningPercentage)) / 100.Screenshot/Video