Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed links to documents from old Harvester versions #1107

Merged

Conversation

juanbrny
Copy link

Summary

Updated links pointing to old 1.1 and 1.2 release documentation.

PR Checklist

  • Is this a multi-tenancy feature/bug?
    • Yes, the relevant RBAC changes are at:
  • Do we need to backport changes to the old Rancher UI, such as RKE1?
    • Yes, the relevant PR is at:
  • Are backend engineers aware of UI changes?
    • Yes, the backend owner is:

Related Issue #

Occurred changes and/or fixed issues

Just links on lables

Technical notes summary

Areas or cases that should be tested

Areas which could experience regressions

None

Screenshot/Video

Fixed several references to documents from old versions. Added new wording to the Upgrade popup as it was referencing the old procedure
Fixed several references to documents from old versions. Added new wording to the Upgrade popup as it was referencing the old procedure
@a110605
Copy link
Collaborator

a110605 commented Aug 21, 2024

Hi @jillian-maroket , could you help take a look this PR ?
Most links change are good to me.

Copy link

@jillian-maroket jillian-maroket left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@juanbrny Thank you for contributing. Please apply the requested changes.

pkg/harvester/l10n/en-us.yaml Outdated Show resolved Hide resolved
pkg/harvester/l10n/en-us.yaml Outdated Show resolved Hide resolved
pkg/harvester/l10n/en-us.yaml Outdated Show resolved Hide resolved
@a110605 a110605 added Bug Fix Something isn't working Documentation Improvements or additions to documentation and removed Bug Fix Something isn't working labels Aug 26, 2024
Signed-off-by: andy.lee <andy.lee@suse.com>
Signed-off-by: andy.lee <andy.lee@suse.com>
@a110605
Copy link
Collaborator

a110605 commented Aug 27, 2024

Hi @jillian-maroket , I've updated with your suggestions. Please have take a look again.

@a110605 a110605 requested a review from bk201 August 27, 2024 03:13
Copy link

@jillian-maroket jillian-maroket left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@a110605 a110605 merged commit 715b58e into harvester:release-harvester-v1.3 Aug 27, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants