feat: Add ability to enable Longhorn V2 Data Engine #1108
Conversation
Related issue: harvester/harvester#5274 Signed-off-by: Tim Serong <tserong@suse.com>
tserong
force-pushed
the
wip-lhv2-enablement
branch
from
443de50
to
3de499e
Compare
|
Force pushed to fix lint errors |
There was a problem hiding this comment.
Looks good 👍 .
Another idea is to add Preview Feature tag with mouse hover tooltip to explian what's preview feature.
previewFeature field can be defined either in frontend or backend that can be modified to false once preview feature is official release.
Refer : a110605@b05b318
|
Oh, that's a neat idea @a110605! I'll add that if nobody objects :-) |
|
I've added that tag now, but reworded it to say "Technical Preview" after consulting with @asettle. Here's a screenshot:
I'm not sure about the "WARNING: THIS IS A PREVIEW FEATURE" item in the bulleted list. Should I reword that too, or just drop it given we have the tag now? |
I think tag is quite clear enough that we don't need "WARNING: THIS IS A PREVIEW FEATURE". |
Signed-off-by: Tim Serong <tserong@suse.com> Co-authored-by: Andy Lee <andy.lee@suse.com>
tserong
force-pushed
the
wip-lhv2-enablement
branch
from
4e0dd75
to
9a523c4
Compare
|
@Mergifyio backport release-harvester-v1.4 |
✅ Backports have been created
|
…v1.4/pr-1108 feat: Add ability to enable Longhorn V2 Data Engine (backport #1108)
Related issue:
Note: this depends on harvester/harvester#6405
Here's an example screenshot showing the setting with its description, along with the error message from Longhorn in the case where hugepages can't be allocated at runtime and a node needs rebooting:
Should add more text explaining what "preview feature" means in this context? Links to external docs? Anything else?