[ui-strings] Consistent language use applied across UI strings #1110
+491
−491
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Issue rancher#6407 - Base UI review performed. Signed-off-by: Alexandra Settle <asettle@suse.com>
a110605
reviewed
Aug 26, 2024
a110605
reviewed
Aug 26, 2024
Signed-off-by: Alexandra Settle <asettle@suse.com>
asettle
commented
Aug 26, 2024
ibrokethecloud
added a commit
to ibrokethecloud/harvester-docs
that referenced
this pull request
Aug 26, 2024
3 tasks
|
@a110605 I will not be able to review this PR any time soon. I suggest that we just apply the suggested changes and do another general review of the strings later on. |
Co-authored-by: Simon Flood
Signed-off-by: Alexandra Settle <asettle@suse.com>
jillian-maroket
pushed a commit
to harvester/docs
that referenced
this pull request
Aug 28, 2024
* addon development guide * include feedback from Kiefer * renamed addon to add-on to better reflect upcoming ui changes: harvester/dashboard#1110 * Apply suggestions from code review include feedback for PR review. Co-authored-by: Jillian <67180770+jillian-maroket@users.noreply.github.com> * Update docs/developer/addon-development.md Co-authored-by: Alexandra Settle <asettle@suse.com> --------- Co-authored-by: Jillian <67180770+jillian-maroket@users.noreply.github.com> Co-authored-by: Alexandra Settle <asettle@suse.com>
a110605
approved these changes
Aug 28, 2024
Signed-off-by: andy.lee <andy.lee@suse.com>
Done solve conflict. |
|
@mergify backport release-harvester-v1.4 |
✅ Backports have been created
|
mergify bot
pushed a commit
that referenced
this pull request
Sep 6, 2024
[ui-strings] Consistent language use applied across UI string (cherry picked from commit f519a8f) # Conflicts: # pkg/harvester/l10n/en-us.yaml
a110605
pushed a commit
to a110605/harvester-dashboard
that referenced
this pull request
Sep 6, 2024
…ster#1110) [ui-strings] Consistent language use applied across UI string
|
@mergify backport release-harvester-v1.4 |
✅ Backports have been created
|
a110605
added a commit
that referenced
this pull request
Sep 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Correct spelling mistakes and base UI review performed:
Related Issue #
Issue #6407