Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed a few typos in en-us.yaml #931

Closed
wants to merge 1 commit into from

Conversation

simonflood
Copy link

Summary

Spotted a couple of typos in Harvester then found more when I checked source

PR Checklist

  • Is this a multi-tenancy feature/bug?
    • Yes, the relevant RBAC changes are at:
  • Do we need to backport changes to the old Rancher UI, such as RKE1?
    • Yes, the relevant PR is at:
  • Are backend engineers aware of UI changes?
    • Yes, the backend owner is:

Fixes #

Fixed typos in UI

Occurred changes and/or fixed issues

Various typos in UI

Technical notes summary

Areas or cases that should be tested

Areas which could experience regressions

Screenshot/Video

Spotted a couple of typos in Harvester then found more when I checked source
@a110605
Copy link
Collaborator

a110605 commented Jun 18, 2024

@simonflood , thanks for fixing the typos in harvester dashboard. It's worth to merge this fixed PR.
Could you help rebase with master ? Thanks.

@a110605
Copy link
Collaborator

a110605 commented Aug 26, 2024

We have another PR fixing those typoes. Let's review and merge that PR and close this one.

@a110605 a110605 closed this Aug 26, 2024
@asettle
Copy link

asettle commented Aug 26, 2024

Some of these I would have missed in my efforts. I'll incorporate the two tomorrow. Thanks @simonflood!

asettle added a commit to asettle/dashboard that referenced this pull request Aug 26, 2024
@simonflood simonflood deleted the patch-1 branch September 11, 2024 10:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants