Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add image restoring status #1112

Merged
merged 1 commit into from
Aug 27, 2024
Merged

Add image restoring status #1112

merged 1 commit into from
Aug 27, 2024

Conversation

a110605
Copy link
Collaborator

@a110605 a110605 commented Aug 27, 2024 •
edited
Loading

Summary

PR Checklist

  • Is this a multi-tenancy feature/bug?
    • Yes, the relevant RBAC changes are at:
  • Do we need to backport changes to the old Rancher UI, such as RKE1?
    • Yes, the relevant PR is at:
  • Are backend engineers aware of UI changes?

Related Issue # [GUI] [FEATURE] Restore vm backup to other harvester cluster

Screenshot/Video

Screenshot 2024-08-27 at 2 54 17 PM

@a110605
Add restoring status for image
0443560 
Signed-off-by: andy.lee <andy.lee@suse.com>
@a110605 a110605 self-assigned this Aug 27, 2024
@a110605 a110605 added the Enhancement minor or greater UI enhancement label Aug 27, 2024
@a110605 a110605 changed the title Add image restoring status for Add image restoring status Aug 27, 2024
FrankYang0529
FrankYang0529 approved these changes Aug 27, 2024
View reviewed changes
Copy link
Member

@FrankYang0529 FrankYang0529 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for the PR.

Screenshot 2024-08-27 at 7 03 15 PM

bk201
bk201 approved these changes Aug 27, 2024
View reviewed changes
Copy link
Member

@bk201 bk201 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@bk201 bk201 merged commit a400046 into harvester:master Aug 27, 2024
10 checks passed
@a110605
Copy link
Collaborator Author

a110605 commented Aug 30, 2024

@mergify backport release-harvester-v1.4

@mergify Mergify
Copy link

mergify bot commented Aug 30, 2024 •
edited
Loading

backport release-harvester-v1.4

✅ Backports have been created

@mergify mergify bot mentioned this pull request Aug 30, 2024
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FrankYang0529 FrankYang0529 FrankYang0529 approved these changes

@bk201 bk201 bk201 approved these changes

@torchiaf torchiaf Awaiting requested review from torchiaf

Assignees

@a110605 a110605

Labels
Enhancement minor or greater UI enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@a110605 @bk201 @FrankYang0529