Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix harvester support link does not link to support page when embedded Rancher 2.9 (backport #1120) #1127

Merged

Conversation

mergify[bot]
Copy link

@mergify mergify bot commented Sep 2, 2024

Summary

Starting from Rancher v2.9 , we have shell/components/templates defines different page layouts for each page in Rancher.

The router defined in shell/config/router/router.js missing name in home block.


To make harvester support page compatible for v2.8.x, v.2.9.0 and v2.9.1, this PR changes harvester support page layout to default.

The different is default layout has sidebar, while home layout doesn't.

default layout
Screenshot 2024-08-29 at 10 23 10 PM

home layout
Screenshot 2024-08-29 at 10 23 21 PM

Note. this PR needs backport to v1.4 and v1.3.

PR Checklist

  • Is this a multi-tenancy feature/bug?
    • Yes, the relevant RBAC changes are at:
  • Do we need to backport changes to the old Rancher UI, such as RKE1?
    • Yes, the relevant PR is at:
  • Are backend engineers aware of UI changes?
    • Yes, the backend owner is:

Related Issue # harvester/harvester#6442

Screenshot/Video

Test on Rancher 2.9

rancher_2.9.mov

Test on Rancher 2.8

rancher_2.8.mov

This is an automatic backport of pull request #1120 done by [Mergify](https://mergify.com).

Signed-off-by: andy.lee <andy.lee@suse.com>
(cherry picked from commit db24008)
@a110605 a110605 self-assigned this Sep 2, 2024
@a110605 a110605 added the Backport to v1.3 Backport PR target v1.3 label Sep 2, 2024
@a110605 a110605 removed their assignment Sep 2, 2024
Copy link
Collaborator

@a110605 a110605 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@a110605 a110605 merged commit 5529fb2 into release-harvester-v1.3 Sep 2, 2024
5 checks passed
@mergify mergify bot deleted the mergify/bp/release-harvester-v1.3/pr-1120 branch September 2, 2024 08:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Backport to v1.3 Backport PR target v1.3
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant