Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add additional-guest-memory-overhead-ratio setting #1128

Merged
merged 1 commit into from
Sep 18, 2024

Conversation

a110605
Copy link
Collaborator

@a110605 a110605 commented Sep 2, 2024

Summary

Add additional-guest-memory-overhead-ratio setting

PR Checklist

  • Is this a multi-tenancy feature/bug?
    • Yes, the relevant RBAC changes are at:
  • Do we need to backport changes to the old Rancher UI, such as RKE1?
    • Yes, the relevant PR is at:
  • Are backend engineers aware of UI changes?

Related Issue #
harvester/harvester#5768 (comment)

Screenshot/Video

ratio-setting.webm

@a110605 a110605 added the Draft PR The PR still no ready label Sep 2, 2024
@w13915984028
Copy link
Member

Thanks @a110605, it looks great.

@w13915984028
Copy link
Member

@a110605 This PR is marked as Draft, do you have plan to remove the Draft, or we review it now? thanks.

BTW, the PR looks good to me.

@a110605
Copy link
Collaborator Author

a110605 commented Sep 9, 2024

@a110605 This PR is marked as Draft, do you have plan to remove the Draft, or we review it now? thanks.

BTW, the PR looks good to me.

Yeah, I need to test it with backend PR harvester/harvester#6438.
Could you provide the harvester/harvester#6438 image ? thanks

@w13915984028
Copy link
Member

@a110605 Sorry I missed the message, the harvester master-head image has included the backend PR. thanks.

Signed-off-by: andy.lee <andy.lee@suse.com>
@a110605 a110605 added New Feature New feature for up coming release and removed Draft PR The PR still no ready labels Sep 13, 2024
@a110605 a110605 marked this pull request as ready for review September 13, 2024 14:28
@a110605
Copy link
Collaborator Author

a110605 commented Sep 13, 2024

@a110605 Sorry I missed the message, the harvester master-head image has included the backend PR. thanks.

@w13915984028 @torchiaf , I have updated this PR and test with harvester master-head deployment.

Copy link
Member

@w13915984028 w13915984028 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks.

Copy link
Collaborator

@torchiaf torchiaf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@a110605 a110605 merged commit 52b2df9 into harvester:master Sep 18, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
New Feature New feature for up coming release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants