-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BUG] Final edits to the UI strings #1176
Conversation
1. Currently unable to chagne the message "VirtualMachine generation is 2..." 2. Discrepency between "cluster flow/flows" etc is out of my control for the UI string changes. Signed-off-by: Alexandra Settle <asettle@suse.com>
You can remove
Same for harvesterhci.io.logging.clusteroutput.vue / flow.vue / output.vue |
Hi @Yu-Jack or @FrankYang0529 , Could you kindly help separate the wording "VirtualMachine" to "Virtual Machine" in harvester/vendor/sigs.k8s.io/cli-utils/pkg/kstatus/status/generic.go ? |
Hi @a110605, we may not be able to do that. harvester/vendor/sigs.k8s.io/cli-utils/pkg/kstatus/status/generic.go is upstream code. Also, VirtualMachine is defined in upstream. |
BTW, it's a |
“VirtualMachine” in “VirtualMachine generation is 2...” means that |
Hmm I understand. That being said, because it's the same text, it looks like a spelling mistake. Can we apply some mark-up to 'VirtualMachine' to ensure it's clear? |
Hi @Yu-Jack , could you help from backend side? |
Hi @a110605. Just like @FrankYang0529 mentioned, it's an upstream code, we can't modify it. So, you probably need to handle it in frontend code for this specific case. |
Quick synced with @Yu-Jack , we don't want to have any change in generic.go, since it's upstream code. cc @bk201 @asettle, can we skip this wording revision or we want to add specific logic in frontend to handle this wording ? |
We can skip. It'll suffice for now. We can create a bug to handle this in later versions. |
…eDisplay (list page title) `
@asettle , I check QA reported unfinished items and seems we are still missing some items
Pushed my 3 commits in this PR. Please check and test them, thx |
Signed-off-by: andy.lee <andy.lee@suse.com>
Signed-off-by: andy.lee <andy.lee@suse.com>
Signed-off-by: andy.lee <andy.lee@suse.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Closes rancher#6407
Issue: harvester/harvester#6407