Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix volume isEncrypted logic #1177

Merged
merged 1 commit into from
Sep 26, 2024
Merged

Fix volume isEncrypted logic #1177

merged 1 commit into from
Sep 26, 2024

Conversation

a110605
Copy link
Collaborator

@a110605 a110605 commented Sep 26, 2024

Summary

Boolean("false") -> true

#1076 (comment)

PR Checklist

  • Is this a multi-tenancy feature/bug?
    • Yes, the relevant RBAC changes are at:
  • Do we need to backport changes to the old Rancher UI, such as RKE1?
    • Yes, the relevant PR is at:
  • Are backend engineers aware of UI changes?

Related Issue #
harvester/harvester#6493

Screenshot/Video

Screenshot 2024-09-26 at 3 25 56 PM

Yu-Jack
Yu-Jack approved these changes Sep 26, 2024
View reviewed changes
Copy link
Collaborator

@Yu-Jack Yu-Jack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for quick fixing.

@a110605
fix volume isEncrypted logic
7eb0dff 
Signed-off-by: andy.lee <andy.lee@suse.com>
@a110605 a110605 merged commit 385a936 into harvester:master Sep 26, 2024
7 checks passed
@mergify mergify bot mentioned this pull request Sep 26, 2024
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Yu-Jack Yu-Jack Yu-Jack approved these changes

@tserong tserong tserong approved these changes

@torchiaf torchiaf Awaiting requested review from torchiaf

Assignees

@a110605 a110605

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@a110605 @tserong @Yu-Jack