Port app-modal to harvester shell (backport #1163) #1187
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Rancher dashboard has already replace
<modal>
to<app-modal>
in below two PRsPromptModal.vue
rancher/dashboard#10556vue-js-modal
withapp-modal
rancher/dashboard#10591PR Checklist
Related Issue #
[BUG] Can't select the harvester version to upgrade in Rancher UI
[BUG] Rancher doesn't use dark mode in popup modals when in Harvester UI
Screenshot/Video
I've tested harvester
Test on embedded mode
This is an automatic backport of pull request #1163 done by [Mergify](https://mergify.com).