Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port app-modal to harvester shell (backport #1163) #1187

Merged

Conversation

mergify[bot]
Copy link

@mergify mergify bot commented Oct 4, 2024

Summary

Rancher dashboard has already replace <modal> to <app-modal> in below two PRs

PR Checklist

  • Is this a multi-tenancy feature/bug?
    • Yes, the relevant RBAC changes are at:
  • Do we need to backport changes to the old Rancher UI, such as RKE1?
    • Yes, the relevant PR is at:
  • Are backend engineers aware of UI changes?
    • Yes, the backend owner is:

Related Issue #
[BUG] Can't select the harvester version to upgrade in Rancher UI
[BUG] Rancher doesn't use dark mode in popup modals when in Harvester UI

Screenshot/Video

I've tested harvester

  • upgrade modal ✅
  • all modals in vm edit page ✅
  • generate support bundle modal✅
  • Novnc customKey modal✅

Test on embedded mode

Screenshot 2024-09-23 at 8 40 18 PM image
This is an automatic backport of pull request #1163 done by [Mergify](https://mergify.com).

Signed-off-by: andy.lee <andy.lee@suse.com>
(cherry picked from commit 85b311d)
Signed-off-by: andy.lee <andy.lee@suse.com>
(cherry picked from commit 5f65595)
Signed-off-by: andy.lee <andy.lee@suse.com>
(cherry picked from commit 874e191)
@mergify mergify bot added the Backport to v1.4 Backport PR target v1.4 label Oct 4, 2024
@mergify mergify bot assigned a110605 Oct 4, 2024
@a110605 a110605 merged commit 1347413 into release-harvester-v1.4 Oct 4, 2024
5 checks passed
@torchiaf torchiaf deleted the mergify/bp/release-harvester-v1.4/pr-1163 branch November 5, 2024 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Backport to v1.4 Backport PR target v1.4
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant