Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename some VM shorthands to Virtual Machine #1192

Merged
merged 2 commits into from
Oct 15, 2024
Merged

Rename some VM shorthands to Virtual Machine #1192

merged 2 commits into from
Oct 15, 2024

Conversation

a110605
Copy link
Collaborator

@a110605 a110605 commented Oct 14, 2024 •
edited
Loading

Summary

Rename

  • Edit VM quota -> Edit Virtual Machine Quota
  • Take VM Snapshot -> Take Virtual Machine Snapshot
  • Target VM -> Target Virtual Machine
  • Source VM -> Source Virtual Machine

PR Checklist

  • Is this a multi-tenancy feature/bug?
    • Yes, the relevant RBAC changes are at:
  • Do we need to backport changes to the old Rancher UI, such as RKE1?
    • Yes, the relevant PR is at:
  • Are backend engineers aware of UI changes?
    • Yes, the backend owner is:

Related Issue #
harvester/harvester#6407 (comment)

Screenshot/Video

Screenshot 2024-10-14 at 4 29 01 PM Screenshot 2024-10-14 at 4 35 21 PM

@a110605
Rename VM quota and VM snapshot
f2e05b1 
Signed-off-by: andy.lee <andy.lee@suse.com>
@a110605 a110605 self-assigned this Oct 14, 2024
@a110605
update target VM and source VM naming
33eabf9 
Signed-off-by: andy.lee <andy.lee@suse.com>
@a110605 a110605 changed the title Rename VM quota and VM snapshot Rename some VM shorthands to Virtual Machine Oct 14, 2024
bk201
bk201 approved these changes Oct 14, 2024
View reviewed changes
Copy link
Member

@bk201 bk201 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cc @TachunLin for possible Cypress tests breaks

TachunLin
TachunLin approved these changes Oct 14, 2024
View reviewed changes
Copy link

@TachunLin TachunLin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
This would really helps to the consistency for cypress test action on feature item and tile. Thanks for bringing the update

@a110605 a110605 merged commit 7d10225 into harvester:master Oct 15, 2024
9 checks passed
@mergify mergify bot mentioned this pull request Oct 15, 2024
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TachunLin TachunLin TachunLin approved these changes

@asettle asettle asettle approved these changes

@bk201 bk201 bk201 approved these changes

Assignees

@a110605 a110605

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@a110605 @bk201 @asettle @TachunLin