Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable volume size input when isLonghornV2 and edit mode #1198

Merged
merged 1 commit into from
Oct 16, 2024

Conversation

a110605
Copy link
Collaborator

@a110605 a110605 commented Oct 16, 2024

Summary

Disable volume size input when isLonghornV2 and edit mode

PR Checklist

  • Is this a multi-tenancy feature/bug?
    • Yes, the relevant RBAC changes are at:
  • Do we need to backport changes to the old Rancher UI, such as RKE1?
    • Yes, the relevant PR is at:
  • Are backend engineers aware of UI changes?

Related Issue #
harvester/harvester#6791

Screenshot/Video

Create mode
Screenshot 2024-10-16 at 2 13 08 PM

Edit mode

Screenshot 2024-10-16 at 2 12 59 PM

@a110605 a110605 self-assigned this Oct 16, 2024
Copy link

@tserong tserong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@tserong tserong added the Backport to v1.4 Backport PR target v1.4 label Oct 16, 2024
@a110605 a110605 merged commit 5f853e8 into harvester:master Oct 16, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Backport to v1.4 Backport PR target v1.4
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants