Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Instructions on handing interactive ISO Install and where to locate grub.cfg #298

Closed
wants to merge 16 commits into from
Closed

Instructions on handing interactive ISO Install and where to locate grub.cfg #298

wants to merge 16 commits into from

Conversation

LucasSaintarbor
Copy link
Contributor

@LucasSaintarbor LucasSaintarbor commented Apr 4, 2023 •
edited
Loading

Summary
In reference to #3590 (https://github.com/harvester/harvester/issues/3590)...there may be times where someone may be dropped into grub2 while the USB based ISO is hooked up.

  • Added what partition to set as root & where to located the grub.cfg from the iso.

Next steps

  • Is this information accurate?
  • Can any details or context be added?
  • Is there a better spot on the page for this info?
  • Add this info to v1.1

@LucasSaintarbor
Added information on handing interactive ISO Install and where to loc…
6ab1d85 
…ate grub.cfg

In reference to #3590 (harvester/harvester#3590), there may be times where someone may be dropped into grub2 while the USB based ISO is hooked up. Added what partition to set as root & where to located the grub.cfg from the iso.
@LucasSaintarbor
Small revision
b208531 
Small revision
@LucasSaintarbor LucasSaintarbor added the documentation Improvements or additions to documentation label Apr 4, 2023
@LucasSaintarbor LucasSaintarbor added this to the v1.2.0 milestone Apr 4, 2023
@LucasSaintarbor LucasSaintarbor self-assigned this Apr 4, 2023
@netlify
Copy link

netlify bot commented Apr 4, 2023 •
edited by guangbochen
Loading

✅ Deploy Preview for harvester-preview ready!

Name Link
🔨 Latest commit 9e604a3
🔍 Latest deploy log https://app.netlify.com/sites/harvester-preview/deploys/64dc0263ec2213066fbe2bf5
😎 Deploy Preview https://64dc0263ec2213066fbe2bf5--harvester-preview.netlify.app

@LucasSaintarbor LucasSaintarbor changed the title Added information on handing interactive ISO Install and where to locate grub.cfg (3590) Add information on handing interactive ISO Install and where to locate grub.cfg (3590) Apr 19, 2023
@LucasSaintarbor LucasSaintarbor changed the title Add information on handing interactive ISO Install and where to locate grub.cfg (3590) (3590) Add information on handing interactive ISO Install and where to locate grub.cfg Apr 19, 2023
irishgordo
irishgordo approved these changes May 8, 2023
View reviewed changes
Copy link
Contributor

@irishgordo irishgordo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good!
I'm adding @bk201 and @masteryyh to review this as well just to double-check to make sure this is what we would want the docs to say.

@irishgordo irishgordo requested review from masteryyh and bk201 May 8, 2023 16:47
@irishgordo irishgordo mentioned this pull request May 8, 2023
Closed
irishgordo
irishgordo requested changes May 8, 2023
View reviewed changes
docs/install/usb-install.md Outdated Show resolved Hide resolved
irishgordo
irishgordo requested changes May 9, 2023
View reviewed changes
docs/install/usb-install.md Outdated Show resolved Hide resolved
docs/install/usb-install.md Outdated Show resolved Hide resolved
docs/install/usb-install.md Outdated Show resolved Hide resolved
LucasSaintarbor and others added 2 commits May 15, 2023 11:57
@LucasSaintarbor
Merge branch 'harvester:main' into 3590-Provide-Information-On-Intera…
1cdeb26 
…ctive-ISO-Install
@LucasSaintarbor @irishgordo
Apply suggestions from code review
a45d24b 
- Use `cat` to view grub.cf file 
- Explain how to launch into the GNU GRUB2 Boot Menu from the ISO

Co-authored-by: Mike Russell <michael.j.russell.email@gmail.com>
@LucasSaintarbor LucasSaintarbor changed the title (3590) Add information on handing interactive ISO Install and where to locate grub.cfg Instructions on handing interactive ISO Install and where to locate grub.cfg Jun 27, 2023
masteryyh
masteryyh approved these changes Aug 14, 2023
View reviewed changes
Copy link
Contributor

@masteryyh masteryyh left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just a few suggestions ;)
BTW please rebase these commits before merging, thanks

docs/install/usb-install.md Outdated Show resolved Hide resolved
@irishgordo
Copy link
Contributor

I'm wondering if this is still relevant now that:
harvester/harvester#3866

Has been fixed.
Should these instructions still be added?
As this all seems to be related, so users shouldn't encounter this in newer versions of Harvester.

cc: @masteryyh @bk201

@guangbochen
Copy link
Contributor

Maybe consider adding this to the v1.1 doc only as v1.2 has already fixed it.

@guangbochen guangbochen mentioned this pull request Aug 25, 2023
Closed
@LucasSaintarbor LucasSaintarbor removed this from the v1.2.0 milestone Sep 7, 2023
@bk201
Copy link
Member

bk201 commented Oct 30, 2023 •
edited
Loading

@LucasSaintarbor We need to rebase the PR to merge it, thanks! And only add this to the version v1.1 doc (#298 (comment))

@bk201
Copy link
Member

bk201 commented Nov 16, 2023

@jillian-maroket Can you help rebase this PR?

LucasSaintarbor
LucasSaintarbor commented Nov 17, 2023
View reviewed changes
Copy link
Contributor Author

@LucasSaintarbor LucasSaintarbor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bk201 Sorry I missed this. Rebased this PR.

Are these changes okay? If they are, I'll add them to the v1.1 docs per comment (#298 (comment))

docs/install/usb-install.md Outdated Show resolved Hide resolved
docs/install/usb-install.md Outdated Show resolved Hide resolved
docs/install/usb-install.md Outdated Show resolved Hide resolved
bk201
bk201 approved these changes Nov 17, 2023
View reviewed changes
Copy link
Member

@bk201 bk201 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks!

@LucasSaintarbor LucasSaintarbor mentioned this pull request Nov 17, 2023
Merged
@bk201
Copy link
Member

bk201 commented Nov 21, 2023

Replace by #478

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@irishgordo irishgordo irishgordo requested changes

@masteryyh masteryyh masteryyh approved these changes

@bk201 bk201 bk201 approved these changes

Assignees

@LucasSaintarbor LucasSaintarbor

Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@LucasSaintarbor @irishgordo @guangbochen @bk201 @masteryyh