Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Rancher Home link and refactor navbar #367

Merged
merged 1 commit into from
Jul 27, 2023

Conversation

vickyhella
Copy link
Contributor

@vickyhella vickyhella commented Jul 26, 2023

This PR:

  1. Adds a home link to the navbar (fixes #339)
  2. Moves the version switch to the left
  3. Removes the Docs link as it's redundant on our site (works the same as the harvester logo in the upper-left corner)

Screenshot:
image

@netlify
Copy link

netlify bot commented Jul 26, 2023

Deploy Preview for harvester-preview ready!

Name Link
🔨 Latest commit 7f56906
🔍 Latest deploy log https://app.netlify.com/sites/harvester-preview/deploys/64c0ea5c0cf7110008da3296
😎 Deploy Preview https://deploy-preview-367--harvester-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@vickyhella vickyhella marked this pull request as ready for review July 26, 2023 09:44
@vickyhella vickyhella added the enhancement New feature or request label Jul 26, 2023
Copy link
Contributor

@LucasSaintarbor LucasSaintarbor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@LucasSaintarbor
Copy link
Contributor

@vickyhella thanks for adding this! I am going to open a separate PR to add a Quick links section similar to Rancher Desktop:
Screenshot 2023-07-27 at 10 53 23 AM

I think it be good to point to https://github.com/harvester/docs and https://harvesterhci.io/

@LucasSaintarbor LucasSaintarbor merged commit 75366f7 into harvester:main Jul 27, 2023
5 checks passed
@vickyhella vickyhella deleted the vk-home-link branch August 17, 2023 01:44
vickyhella added a commit to vickyhella/harvester-docs that referenced this pull request Sep 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add backlink to rancher.com to header
3 participants