doc: Update Harvester Addon Configuration Examples #368
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for harvester-preview ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
irishgordo
force-pushed
the
fix/update-addon-config-examples
branch
from
4984d92
to
1f92c03
Compare
guangbochen
reviewed
Aug 9, 2023
irishgordo
force-pushed
the
fix/update-addon-config-examples
branch
from
1f92c03
to
7fbe1d6
Compare
* updating Harvester addon configuration docs to represent the yaml more accurately * updating the Harvester addon docs to display information surrounding the naming that is displayed in the UI to the end user in contrast to the naming that is displayed via kubectl commands to the cluster that demonstrate the "chartName" Resolves: fix/update-addon-config-examples
irishgordo
force-pushed
the
fix/update-addon-config-examples
branch
from
7fbe1d6
to
8f49f2f
Compare
|
Deprecating this PR - will open another - rebased but amended commit, causing overwriting of git history. |
Thanks @irishgordo! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Super willing to iterate and update this as needed but wanted to push up a slight change 😄
Given that there is a distinction between UI "naming" and Helm Chart naming:
And that in order for the configuration to work, if serving remotely as a configuration, the syntax in the YAML will need to change shifting from
-(hypens) to_(underscores).Additionally, sharing out to docs about
valuescontentas a property on the addon.This PR updates the way the user is informed of:
valuescontentproperty as a configuration element