Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add multi CSI support summary and csi-driver-config setting #372

Merged

Conversation

LucasSaintarbor
Copy link
Contributor

References harvester/harvester#2405, harvester/harvester#3666

Documents multi CSI support on StorageClass page and explains how to edit the new csi-driver-config setting

@netlify
Copy link

netlify bot commented Jul 28, 2023

Deploy Preview for harvester-preview ready!

Name Link
🔨 Latest commit f8ab9b1
🔍 Latest deploy log https://app.netlify.com/sites/harvester-preview/deploys/64d29e124df8010008b95e95
😎 Deploy Preview https://deploy-preview-372--harvester-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@LucasSaintarbor LucasSaintarbor added this to the v1.2.0 milestone Jul 28, 2023
Copy link
Contributor

@futuretea futuretea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks. Just need to squash commits

Copy link
Member

@lanfon72 lanfon72 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#3666 also introduce:

  • Add a new option os.persistent_state_paths to the Harvester OS configuration.
  • Add a new option os.after_install_chroot_commands to the Harvester OS configuration.

Both would need to add into install/harvester-configuration.md

@LucasSaintarbor
Copy link
Contributor Author

#3666 also introduce:

  • Add a new option os.persistent_state_paths to the Harvester OS configuration.
  • Add a new option os.after_install_chroot_commands to the Harvester OS configuration.

Both would need to add into install/harvester-configuration.md

@lanfon72 I added os.persistent_state_paths and os.after_install_chroot_commands to install/harvester-configuration.md. Not sure where to add these to the new options in ## Configuration Example, may you update the config example + review to the definition and example for each option? Thanks!

@lanfon72
Copy link
Member

lanfon72 commented Aug 2, 2023

Thank you @LucasSaintarbor, it looks good enough for me. 😸 I think it should be fine to not update the content of Configuration Example, both configure options are optional.

For os.after_install_chroot_commands, was tested in #harvester/3689, and there have a caveat that the nameserver might not available, so user would need to update /etc/resolv.conf manually while using the configure option to install package with URL. 1

Footnotes

  1. https://github.com/harvester/harvester/issues/3689#issuecomment-1563130124

@futuretea
Copy link
Contributor

@LucasSaintarbor
Copy link
Contributor Author

@futuretea Added the note you referenced for making changes persistent across an upgrade (#372 (comment))

@lanfon72 Added info and example about accessing a domain name to install package using an URL (#372 (comment))

PTAL, thanks!

@lanfon72 lanfon72 self-requested a review August 10, 2023 10:31
Copy link
Member

@lanfon72 lanfon72 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks

@LucasSaintarbor LucasSaintarbor merged commit 06e65ed into harvester:main Aug 10, 2023
5 checks passed
vickyhella pushed a commit to vickyhella/harvester-docs that referenced this pull request Sep 4, 2023
…r#372)

* Adding setting definition for `csi-driver-config`

* Add Multi Container Storage Interface support section to StoageClass page

* Small changes

* Add link to docs/advanced/settings.md#csi-driver-config

* Fix link to ## `csi-driver-config`

* Add `os.persistent_state_paths` and `os.after_install_chroot_commands` to Harvester configuration

* Add note for os.after_install_chroot_commands (https://github.com/harvester/harvester/blob/master/enhancements/20230316-multi-csi-support.md?plain=1#L137)

* Rephrase `os.after_install_chroot_commands` note

* Added info and example about accessing a domain name to install package with URL in Harvester config (harvester#372 (comment))

* Rephrased note on making changes persistent across an upgrade
@jeff-radick-suse
Copy link

I've modified the content and pushed a few commits. There was some description of the procedure that was clumsy and which is now simplified, and some important stuff that was missing. I tried to follow the formatting changes but I'm not sure I have it right. At any rate the semantic content is complete as far as I can tell, as long as no reviewers find errors.

@LucasSaintarbor LucasSaintarbor deleted the ls-2405-external-storage branch September 20, 2023 20:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants