-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mark those unavailable addons on ARM64 #605
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: Jian Wang <jian.wang@suse.com>
@bk201 @ibrokethecloud @jillian-maroket Seems we did not add something about ARM64 supporting on the Harvester document. Any plans to add a separate chapter? thanks. This PR is a minor update about those unavailable addons. |
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"incompatible" seems more appropriate. I added "currently" because I assume that an ARM64-compatible package might be available in the future.
@@ -10,6 +10,8 @@ title: "PCI Devices" | |||
|
|||
_Available as of v1.1.0_ | |||
|
|||
_Unavailable on ARM64 architecture_ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
_Unavailable on ARM64 architecture_ | |
_Currently incompatible with ARM64_ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We already have content like _Available as of v1.2.0_
, I would prefer _Unavailable on ARM64 architecture_
; maybe put them in same line is better.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Availability and compatibility are two different concepts. You can put them in the same line if you want, but I do not agree with using the draft wording.
@@ -10,6 +10,8 @@ title: "Seeder" | |||
|
|||
_Available as of v1.2.0_ | |||
|
|||
_Unavailable on ARM64 architecture_ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
_Unavailable on ARM64 architecture_ | |
_Currently incompatible with ARM64_ |
@@ -10,6 +10,8 @@ title: "VM Import" | |||
|
|||
_Available as of v1.1.0_ | |||
|
|||
_Unavailable on ARM64 architecture_ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
_Unavailable on ARM64 architecture_ | |
_Currently incompatible with ARM64_ |
@@ -10,6 +10,8 @@ title: "PCI Devices" | |||
|
|||
_Available as of v1.1.0_ | |||
|
|||
_Unavailable on ARM64 architecture_ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
_Unavailable on ARM64 architecture_ | |
_Currently incompatible with ARM64_ |
@@ -10,6 +10,8 @@ title: "Seeder" | |||
|
|||
_Available as of v1.2.0_ | |||
|
|||
_Unavailable on ARM64 architecture_ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
_Unavailable on ARM64 architecture_ | |
_Currently incompatible with ARM64_ |
@@ -10,6 +10,8 @@ title: "VM Import" | |||
|
|||
_Available as of v1.1.0_ | |||
|
|||
_Unavailable on ARM64 architecture_ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
_Unavailable on ARM64 architecture_ | |
_Currently incompatible with ARM64_ |
I don't know if any of the engineers plan to create a PR for this. The only content I wrote for this feature is in the release notes: ARM Support (Technical Preview) @bk201 What other information can we provide to customers? |
We may add a new chapter If no one is working on it, I will file another PR. |
from an end user perspective the Harvester UX is same across both architectures. the addons were not packaged in 1.3.0 due to time constraints. this should be addressed in 1.4.0 where all addons will be available for arm architecture as well. |
Problem:
Addon & repo chart version mis-matching (e.g. harvester/harvester#5840)
Add version matching check.
Solution:
Per comment harvester/harvester-installer#750 (comment), noticed we did not mark the addon on documents.