feat: add rancher-terraform and import-existing-vm #610
Conversation
|
docs/rancher/rancher-terraform.md
Outdated
| - enable | ||
| - '--now' | ||
| - qemu-guest-agent.service | ||
| password: test |
There was a problem hiding this comment.
Let's remove this from the example, it's good for debugging purposes but not for production.
There was a problem hiding this comment.
Yes, removed it. Thanks.
There was a problem hiding this comment.
This is great! just two minor comments.
Thanks @FrankYang0529
docs/rancher/csi-driver.md
Outdated
|
|
||
| ### Upgrade RKE2 | ||
|
|
||
| You can upgrade the CSI driver by upgrading RKE2 using the Rancher UI. |
There was a problem hiding this comment.
Can we write description something like below
"To upgrade the CSI driver, use the Rancher UI to upgrade RKE2. Ensure the new RKE2 version supports/bundled with the updated CSI driver version."
As, simply upgrading RKE2 will not upgrade the CSI driver. WDYT?
There was a problem hiding this comment.
Agree, updated it. Thanks for the suggestion.
docs/rancher/import-existing-vm.md
Outdated
| --- | ||
| sidebar_position: 8 | ||
| sidebar_label: Import Existing VM | ||
| title: "Import Existing VM" |
There was a problem hiding this comment.
Should this be "Import Existing Cluster built on Harvester VM"?
There was a problem hiding this comment.
Yes, that is better. Updated it!
Signed-off-by: PoAn Yang <yangpoan@gmail.com>
Co-authored-by: Jillian <67180770+jillian-maroket@users.noreply.github.com>
Co-authored-by: Jillian <67180770+jillian-maroket@users.noreply.github.com>
Co-authored-by: Jillian <67180770+jillian-maroket@users.noreply.github.com>
Co-authored-by: Jillian <67180770+jillian-maroket@users.noreply.github.com>
Co-authored-by: Jillian <67180770+jillian-maroket@users.noreply.github.com>
Co-authored-by: Jillian <67180770+jillian-maroket@users.noreply.github.com>
Co-authored-by: Jillian <67180770+jillian-maroket@users.noreply.github.com>
Co-authored-by: Jillian <67180770+jillian-maroket@users.noreply.github.com>
Co-authored-by: Jillian <67180770+jillian-maroket@users.noreply.github.com>
Co-authored-by: Jillian <67180770+jillian-maroket@users.noreply.github.com>
Co-authored-by: Jillian <67180770+jillian-maroket@users.noreply.github.com>
Co-authored-by: Jillian <67180770+jillian-maroket@users.noreply.github.com>
Co-authored-by: Jillian <67180770+jillian-maroket@users.noreply.github.com>
Co-authored-by: Jillian <67180770+jillian-maroket@users.noreply.github.com>
Signed-off-by: PoAn Yang <yangpoan@gmail.com>
Signed-off-by: PoAn Yang <poan.yang@suse.com>
|
|
||
| ### Upgrade RKE2 | ||
| The csi driver can be upgraded by upgrading the RKE2 version. You can upgrade the RKE2 cluster via the Rancher UI as follows: |
There was a problem hiding this comment.
Looks like, the statement is missed to be modified at the version level doc.
The CSI driver can be upgraded by upgrading the RKE2 version, provided the RKE2 version is bundled with the new CSI version. You can upgrade the RKE2 cluster via the Rancher UI as follows:
There was a problem hiding this comment.
Thank you. Updated it.
Signed-off-by: PoAn Yang <poan.yang@suse.com>
harvester/harvester#6147