-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Developer docs update #625
Conversation
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall LGTM. Leave a minor comment.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please use the suggested wording and markup (only one note for both sentences), and apply the same changes to the v1.3.0 document. Thank you for contributing.
dd36977
to
8011d9c
Compare
Added note that RKE2/Rancher have to be fully up before continuing with next steps. Co-Authored-By: Jillian <67180770+jillian-maroket@users.noreply.github.com>
Hello, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I fixed the indentation issue and reviewed the new note.
versioned_docs/version-v1.3/developer/developer-mode-installation.md
Outdated
Show resolved
Hide resolved
versioned_docs/version-v1.3/developer/developer-mode-installation.md
Outdated
Show resolved
Hide resolved
Co-authored-by: Jillian <67180770+jillian-maroket@users.noreply.github.com>
Co-authored-by: Jillian <67180770+jillian-maroket@users.noreply.github.com>
…ion.md Co-authored-by: Jillian <67180770+jillian-maroket@users.noreply.github.com>
…ion.md Co-authored-by: Jillian <67180770+jillian-maroket@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks again for contributing.
Added note that RKE2/Rancher have to be fully up before continuing with next steps. In case commands are executed too fast (before RKE2/Rancher are fully up) Harvester will not be accessible.