Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Developer docs update #625

Merged
merged 5 commits into from
Aug 23, 2024
Merged

Developer docs update #625

merged 5 commits into from
Aug 23, 2024

Conversation

mlacko64
Copy link
Contributor

Added note that RKE2/Rancher have to be fully up before continuing with next steps. In case commands are executed too fast (before RKE2/Rancher are fully up) Harvester will not be accessible.

Copy link

github-actions bot commented Aug 19, 2024

Name Link
🔨 Latest commit 33777c4
😎 Deploy Preview https://66c838ac882f3d34aac7375e--harvester-preview.netlify.app

Copy link
Member

@FrankYang0529 FrankYang0529 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall LGTM. Leave a minor comment.

docs/developer/developer-mode-installation.md Outdated Show resolved Hide resolved
Copy link
Contributor

@jillian-maroket jillian-maroket left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use the suggested wording and markup (only one note for both sentences), and apply the same changes to the v1.3.0 document. Thank you for contributing.

docs/developer/developer-mode-installation.md Outdated Show resolved Hide resolved
Added note that RKE2/Rancher have to be fully up before continuing with next steps.

Co-Authored-By: Jillian <67180770+jillian-maroket@users.noreply.github.com>
@mlacko64
Copy link
Contributor Author

Hello,
thanks for reviewing; I have used suggested wording and markup and also added same change to 1.3 docs file. Squashed commits to one and updated commit message.

Copy link
Contributor

@jillian-maroket jillian-maroket left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I fixed the indentation issue and reviewed the new note.

docs/developer/developer-mode-installation.md Outdated Show resolved Hide resolved
docs/developer/developer-mode-installation.md Outdated Show resolved Hide resolved
mlacko64 and others added 4 commits August 23, 2024 09:05
Co-authored-by: Jillian <67180770+jillian-maroket@users.noreply.github.com>
Co-authored-by: Jillian <67180770+jillian-maroket@users.noreply.github.com>
…ion.md

Co-authored-by: Jillian <67180770+jillian-maroket@users.noreply.github.com>
…ion.md

Co-authored-by: Jillian <67180770+jillian-maroket@users.noreply.github.com>
Copy link
Contributor

@jillian-maroket jillian-maroket left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks again for contributing.

@jillian-maroket jillian-maroket merged commit eac4857 into harvester:main Aug 23, 2024
3 checks passed
@mlacko64 mlacko64 deleted the devdocs branch August 23, 2024 07:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants