Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

intro to cloud-init crd #630

Merged
merged 3 commits into from
Sep 2, 2024

Conversation

ibrokethecloud
Copy link
Contributor

PR documents the usage of the Harvester CloudInit CRD.

Related to: harvester/harvester#5240

Copy link

github-actions bot commented Aug 26, 2024

Name Link
🔨 Latest commit 221072e
😎 Deploy Preview https://66d505f3b075bd65b7642260--harvester-preview.netlify.app

Copy link
Contributor

@jillian-maroket jillian-maroket left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let me know if you have concerns about the changes.

docs/advanced/cloudinitcrd.md Outdated Show resolved Hide resolved
docs/advanced/cloudinitcrd.md Outdated Show resolved Hide resolved
docs/advanced/cloudinitcrd.md Outdated Show resolved Hide resolved
docs/advanced/cloudinitcrd.md Outdated Show resolved Hide resolved
docs/advanced/cloudinitcrd.md Outdated Show resolved Hide resolved
docs/advanced/cloudinitcrd.md Outdated Show resolved Hide resolved
include feedback from Jillian

Co-authored-by: Jillian <67180770+jillian-maroket@users.noreply.github.com>
Copy link
Member

@bk201 bk201 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. need to add versions 1.3 files too.

Copy link
Contributor

@jillian-maroket jillian-maroket left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Please add the file to the v1.3 doc. Thank you!

@ibrokethecloud ibrokethecloud merged commit b63e7e8 into harvester:main Sep 2, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants