Add CPU Pinning document #639
Conversation
|
brandboat
force-pushed
the
HARV-6148
branch
from
b93d1b0
to
87a321e
Compare
docs/vm/cpu-pinning.md
Outdated
|
|
||
| ### Limitations | ||
|
|
||
| - Only one master node can enable/disable the CPU Manager at a time. |
There was a problem hiding this comment.
we need to rephrase this, since the CPU manager can be enable on any node in the cluster except the witness node
There was a problem hiding this comment.
Thanks, already refine the limitations part, also add description about what harvester behaves after user checks the enable CPU pinning checkbox in virtual machine page. As you mentioned offline, this would help user understand how to enable cpu pinning via YAML.
Signed-off-by: Cooper Tseng <cooper.tseng@suse.com>
brandboat
force-pushed
the
HARV-6148
branch
from
87a321e
to
ff6baab
Compare
docs/vm/cpu-pinning.md
Outdated
| - Only one master node can enable or disable the CPU Manager at a time. Note that the witness node cannot perform these actions. | ||
| - You must wait for an operation (enable/disable) to finish before starting another on the same node. | ||
| - Any VMs with CPU pinning enabled must be stopped before disabling CPU Manager on that node. |
There was a problem hiding this comment.
| - Only one master node can enable or disable the CPU Manager at a time. Note that the witness node cannot perform these actions. | |
| - You must wait for an operation (enable/disable) to finish before starting another on the same node. | |
| - Any VMs with CPU pinning enabled must be stopped before disabling CPU Manager on that node. | |
| - The CPU Manager cannot be enabled on the witness node. | |
| - You can enable or disable the CPU Manager on only one management node at a time. | |
| - You must wait for an operation (enabling or disabling) to be completed before starting another. | |
| - VMs with CPU pinning enabled must be stopped before CPU Manager is disabled on the corresponding node. |
There was a problem hiding this comment.
CPU manager is not limited to management/controlplane node, it can be enable on any node in the cluster. We shoudl rephrase this to better reflect this
You can enable or disable the CPU Manager on only one management node at a time.
There was a problem hiding this comment.
Thanks for the comment @ibrokethecloud ! What I want to emphasize here is that users could only enable/disable cpu manager on one management node at the same time.
Just a note, I add this limitation since enable/disable cpu manager requires restarting rke2-server on management node, if all rke2-server are restarting in the same time, that would cause whole cluster unavailable.
docs/vm/cpu-pinning.md
Outdated
|
|
||
| - The CPU Manager cannot be enabled on the witness node. | ||
|
|
||
| - You can enable or disable the CPU Manager on only one management node at a time. |
There was a problem hiding this comment.
This sounds like when a user enables CPU manager on a management node and after the operation finishes, he/she can't enable another management node. It would be nice to re-phase it more clearly.
related to harvester/harvester#6148, add cpu pinning document.