-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: add local storage support #663
Conversation
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
(I did notice one or two little wording things like "You can refer Multi-Disk Management for how to add disks" should be "You can refer to Multi-Disk Management...", and I think we generally have a preference for spelling out "virtual machine" in full rather than using "VM", but @jillian-maroket is going to do a much better job of reviewing the wording than I am, so I didn't add any inline comments on this stuff.)
02ea316
to
11d021b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I rewrote and restructured all of the sections, and added content where necessary. Another round of edits may be necessary after you respond to my comments.
0cd1d8d
to
ae7da95
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I suggest removing all mentions of backup creation for now. PTAL at the new note in the last section.
Signed-off-by: Vicente Cheng <freeze.bilsted@gmail.com> Co-authored-by: Jillian <67180770+jillian-maroket@users.noreply.github.com>
dc0b35c
to
8cde017
Compare
Related: harvester/harvester#5724