Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add local storage support #663

Merged
merged 1 commit into from
Nov 7, 2024

Conversation

Vicente-Cheng
Copy link
Contributor

@Vicente-Cheng
Copy link
Contributor Author

Vicente-Cheng commented Nov 5, 2024

I will work on the https://docs.harvesterhci.io/v1.3/host/#multi-disk-management to link both LonghornV2/LVM volumes.
The multi-disk management update PR: #664

cc @tserong, @jillian-maroket, @bk201

Copy link

github-actions bot commented Nov 5, 2024

Name Link
🔨 Latest commit 8cde017
😎 Deploy Preview https://672c5a0c0393340177383c0c--harvester-preview.netlify.app

Copy link
Contributor

@tserong tserong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

(I did notice one or two little wording things like "You can refer Multi-Disk Management for how to add disks" should be "You can refer to Multi-Disk Management...", and I think we generally have a preference for spelling out "virtual machine" in full rather than using "VM", but @jillian-maroket is going to do a much better job of reviewing the wording than I am, so I didn't add any inline comments on this stuff.)

Copy link
Contributor

@jillian-maroket jillian-maroket left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I rewrote and restructured all of the sections, and added content where necessary. Another round of edits may be necessary after you respond to my comments.

docs/advanced/addons/lvm-local-storage.md Outdated Show resolved Hide resolved
docs/advanced/addons/lvm-local-storage.md Outdated Show resolved Hide resolved
docs/advanced/addons/lvm-local-storage.md Outdated Show resolved Hide resolved
docs/advanced/addons/lvm-local-storage.md Outdated Show resolved Hide resolved
docs/advanced/addons/lvm-local-storage.md Outdated Show resolved Hide resolved
docs/advanced/addons/lvm-local-storage.md Outdated Show resolved Hide resolved
docs/advanced/addons/lvm-local-storage.md Outdated Show resolved Hide resolved
docs/advanced/addons/lvm-local-storage.md Outdated Show resolved Hide resolved
docs/advanced/addons/lvm-local-storage.md Outdated Show resolved Hide resolved
docs/advanced/addons/lvm-local-storage.md Outdated Show resolved Hide resolved
Copy link
Contributor

@jillian-maroket jillian-maroket left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggest removing all mentions of backup creation for now. PTAL at the new note in the last section.

docs/advanced/addons/lvm-local-storage.md Outdated Show resolved Hide resolved
docs/advanced/addons/lvm-local-storage.md Outdated Show resolved Hide resolved
docs/advanced/addons/lvm-local-storage.md Outdated Show resolved Hide resolved
Signed-off-by: Vicente Cheng <freeze.bilsted@gmail.com>
Co-authored-by: Jillian <67180770+jillian-maroket@users.noreply.github.com>
@bk201 bk201 merged commit d52a063 into harvester:main Nov 7, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants