Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: update the rwx volume document #699

Merged
merged 1 commit into from
Feb 3, 2025

Conversation

Vicente-Cheng
Copy link
Contributor

@Vicente-Cheng Vicente-Cheng commented Jan 2, 2025

Related issues:
harvester/harvester#7158
harvester/harvester#7138

For v1.4, we need to use storage network for this feature.
Update the RWX volume document.

@Vicente-Cheng
Copy link
Contributor Author

I will move these changes to v1.4 after the reviews

@innobead
Copy link

innobead commented Jan 2, 2025

Let's associate this with a relevant issue for clarity.

Copy link

github-actions bot commented Jan 2, 2025

Name Link
🔨 Latest commit 29b57bf
😎 Deploy Preview https://6780de22005f170849e096e1--harvester-preview.netlify.app

@Vicente-Cheng
Copy link
Contributor Author

Let's associate this with a relevant issue for clarity.

updated

Copy link
Contributor

@jillian-maroket jillian-maroket left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review done

docs/rancher/csi-driver.md Outdated Show resolved Hide resolved
docs/rancher/csi-driver.md Outdated Show resolved Hide resolved
docs/rancher/csi-driver.md Outdated Show resolved Hide resolved
docs/rancher/csi-driver.md Outdated Show resolved Hide resolved
docs/rancher/csi-driver.md Outdated Show resolved Hide resolved
@Vicente-Cheng
Copy link
Contributor Author

Review done

Updated to both dev/v1.4

Copy link
Contributor

@jillian-maroket jillian-maroket left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed the new note

docs/rancher/csi-driver.md Outdated Show resolved Hide resolved
@Vicente-Cheng Vicente-Cheng force-pushed the update-rwx-volume-support branch 2 times, most recently from 413133b to d3b7b82 Compare January 10, 2025 08:24
Signed-off-by: Vicente Cheng <vicente.cheng@suse.com>
Co-authored-by: Jillian <67180770+jillian-maroket@users.noreply.github.com>
@Vicente-Cheng Vicente-Cheng force-pushed the update-rwx-volume-support branch from d3b7b82 to 29b57bf Compare January 10, 2025 08:27
@Vicente-Cheng
Copy link
Contributor Author

Vicente-Cheng commented Jan 10, 2025

Hi @jillian-maroket,

I made some minor changes as below:

- - The guest cluster has two network interfaces (`mgmt` and the storage network).
+ - The VM must have two interfaces. The first one is the default network interface for cluster/external networking. The second one must be in a network which can connect to the storage network.

Could you help to check again?
Thanks!

### Prerequisites

- Harvester v1.4 or later is installed on the host cluster.

- Create [Storage Network](../advanced/storagenetwork.md) and configure it on Harvester cluster.

We need to reserve a range for the VMs of guest cluster. Please use **exclude** to reserve some IP addresses.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

need a hint on how many IPs to reserve.

Copy link
Contributor

@jillian-maroket jillian-maroket left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, missed the update. See my comment about cluster/external networking.

@@ -377,6 +395,12 @@ Now you can create a new StorageClass that you intend to use in your guest Kuber
harvester-networkfs-manager-xvkgp 1/1 Running 4 (37m ago) 3h41m
```

- The VM must have two interfaces. The first one is the default network interface for cluster/external networking. The second one must be in a network which can connect to the storage network.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- The VM must have two interfaces. The first one is the default network interface for cluster/external networking. The second one must be in a network which can connect to the storage network.
- The virtual machine must have two network interfaces: 1) the default network interface for intra-cluster communications and allowing access from the infrastructure network (external to the Harvester cluster); and 2) a network that can connect to the storage network.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cluster/external networking was a bit vague. Is this what you mean?

@@ -391,6 +415,21 @@ Now you can create a new StorageClass that you intend to use in your guest Kuber

- SUSE and OpenSUSE: `zypper install -y nfs-client`

- An IP is manually assigned to the storage network interface.

You can assign any of the reserved IPs using the following commands:

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a side topic. Don't we have any IPAM in this case? @starbops

@dfaltum
Copy link

dfaltum commented Feb 3, 2025

Are you guys waiting for me with this PR? I'm being asked for a review, but I don't have permission to approve it :)

@bk201 bk201 merged commit e3baa99 into harvester:main Feb 3, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants