Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2995 check if storage network attached before cluster network and vlan config config deletion (backport #115) #122

Merged
merged 2 commits into from
Sep 19, 2024

Conversation

mergify[bot]
Copy link

@mergify mergify bot commented Sep 19, 2024

Problem:
1.User can delete the cluster network when storage network NAD is still attached to it.
2.User can delete the vlan config when storage network NAD is still attached to it.

The above breaks the networking functionality of storage networks without user being notified.

Solution:
Do not delete the cluster network or vlan config if storage network still exists for the cluster.

Related Issue:

Test plan:
Manually validated in a harvester node.

Reference bug report:
harvester/tests#1311

Negative: Delete cluster network when already set on storage network

Navigate to Networks -> Cluster Networks/Configs, create Cluster Network named vlan2
Create Network Config vlan2-config for all nodes
Navigate to Advanced -> Settings, edit storage-network
Select Enable then select vlan2 as cluster network, fill in VLAN ID and IP Range
Navigate to Networks -> Cluster Networks/Configs, delete Cluster Network vlan2
Warning or error message should displayed

Negative: Delete vlan config when already set on storage network

Navigate to Networks -> Cluster Networks/Configs, create Cluster Network named vlan2
Create Network Config vlan2-config for all nodes
Navigate to Advanced -> Settings, edit storage-network
Select Enable then select vlan2 as cluster network, fill in VLAN ID and IP Range
Navigate to Networks -> Cluster Networks/Configs, delete network config vlan2-config
Warning or error message should displayed

This is an automatic backport of pull request #115 done by [Mergify](https://mergify.com).

@starbops starbops merged commit bf961d7 into v0.5.x Sep 19, 2024
4 checks passed
@mergify mergify bot deleted the mergify/bp/v0.5.x/pr-115 branch September 19, 2024 08:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants