2995 check if storage network attached before cluster network and vlan config config deletion (backport #115) #122
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem:
1.User can delete the cluster network when storage network NAD is still attached to it.
2.User can delete the vlan config when storage network NAD is still attached to it.
The above breaks the networking functionality of storage networks without user being notified.
Solution:
Do not delete the cluster network or vlan config if storage network still exists for the cluster.
Related Issue:
Test plan:
Manually validated in a harvester node.
Reference bug report:
harvester/tests#1311
Negative: Delete cluster network when already set on storage network
Negative: Delete vlan config when already set on storage network
This is an automatic backport of pull request #115 done by [Mergify](https://mergify.com).