feat: add Longhorn V2 provisioner #129
Conversation
tserong
force-pushed
the
wip-lhv2-provisioner
branch
from
3af18bd
to
f264830
Compare
|
OK, that force push should have fixed the dirty validation, and we can ignore CodeFactor, because it's just whining about generated code :-) Some further comments lifted from the commit message on the last commit: I've implemented this as a separate The current implementation theoretically supports using virtio disks, except that NDM as a whole ignores those, as they don't have WWNs. This is something we need to address separately as part of harvester/harvester#6034 |
tserong
force-pushed
the
wip-lhv2-provisioner
branch
from
f264830
to
35bce97
Compare
|
This pull request is now in conflict. Could you fix it @tserong? 🙏 |
Signed-off-by: Tim Serong <tserong@suse.com>
Signed-off-by: Tim Serong <tserong@suse.com>
This allows adding extra disks for use by Longhorn's V2 data engine. I've implemented this as a separate LonghornV2Provisioner for the sake of neatness, rather than grafting it into LonghornV1Provisioner with a bunch of `if` statements, but some of the implementation (the UnProvision() and Update() functions) still call back to the LonghornV1Provisioner to avoid excessive code duplication. The current implementation theoretically supports using virtio disks, except that NDM as a whole ignores those, as they don't have WWNs. This is something we need to address separately as part of harvester/harvester#6034 Related issue: harvester/harvester#5274 Signed-off-by: Tim Serong <tserong@suse.com>
tserong
force-pushed
the
wip-lhv2-provisioner
branch
from
1fac580
to
f530971
Compare
|
@Mergifyio backport v0.7.x |
✅ Backports have been created
|
|
OK, I give up, obviously I can't get mergify to redo a backport PR, I'm just going to do this by hand... (see #133) |
Problem:
We need to add a provisioner for LH V2 disks
Solution:
This PR
Related Issue:
harvester/harvester#6014
harvester/harvester#5274
Test plan:
TBD
Note:
The first two commits in this PR are cherry picks from #128, because I needed the changes to the blockdevices CRD. I'll drop/rebase appropriately once that PR goes in.