controller: consider the new provision field #139
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- improve the whole handling with the new provision field Signed-off-by: Vicente Cheng <vicente.cheng@suse.com>
Vicente-Cheng
force-pushed
the
fix-side-effect-from-new-fields
branch
from
febdb95
to
f7e4cbe
Compare
3 tasks
|
@Mergifyio backport v0.7.x |
✅ Backports have been created
|
bk201
approved these changes
Sep 25, 2024
tserong
approved these changes
Sep 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem:
Missing mountpoint when provisioning the longhorn V1
Solution:
We need to improve the handling with the new provision field
Spec.Provision.Walk through the whole
Spec.Filesystem.Provisionedlogic and improve them.Related Issue:
None
Test plan:
Make sure the longhornV1 can works as usual only with the new provision field
Spec.Provision.