change pod mutation webhook logic for kubevirt v1.1.x support #70
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bk201
approved these changes
Mar 15, 2024
|
For Harvester v1.2 the VM (with PCI device) couldn't be booted up unless applying fix memory overcommit. |
Per discussion with @ibrokethecloud Because the fix memory overcommit also includes other vGPU changes, we will manually to the backport. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IMPORTANT: Please do not create a Pull Request without creating an issue first.
Problem:
PCIDevice passthrough is currently broken in v1.2-head due to upgrade to kubevirt v1.1.x
This is due to the change in launcher pod now running two containers rather than the original one in v0.55.x
Solution:
The PR manually backports the changes to pod mutation in webhook from master branch. This has already been fixed in v1.3.0
Related Issue:
harvester/harvester#5373
Test plan: