-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
migrate from drone ci to gh actions #75
Conversation
b2cc0d0
to
84e640c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same as others, we should generate amd64 and arm64 build, and move specified binary in Dockerfile.
https://github.com/rancher/support-bundle-kit/blob/master/scripts/build
https://github.com/rancher/support-bundle-kit/blob/master/package/Dockerfile
I checked with running github actions locally, and the control flow works file, just the arm64 image contains x86 binary as @Yu-Jack mentioned. Checked the arm64 image binary with the following commands:
Thanks. |
tidy up template tidy up template
5939ee3
to
31ec7e5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks.
IMPORTANT: Please do not create a Pull Request without creating an issue first.
Problem:
PR migrations CI from drone to gh actions
Solution:
Related Issue:
harvester/harvester#5327
Test plan: