Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

migrate from drone ci to gh actions #75

Merged
merged 1 commit into from
Apr 24, 2024

Conversation

ibrokethecloud
Copy link
Collaborator

IMPORTANT: Please do not create a Pull Request without creating an issue first.

Problem:

PR migrations CI from drone to gh actions
Solution:

Related Issue:
harvester/harvester#5327
Test plan:

Copy link
Contributor

@Yu-Jack Yu-Jack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as others, we should generate amd64 and arm64 build, and move specified binary in Dockerfile.

https://github.com/rancher/support-bundle-kit/blob/master/scripts/build
https://github.com/rancher/support-bundle-kit/blob/master/package/Dockerfile

@WebberHuang1118
Copy link
Member

WebberHuang1118 commented Apr 24, 2024

I checked with running github actions locally, and the control flow works file, just the arm64 image contains x86 binary as @Yu-Jack mentioned.

Checked the arm64 image binary with the following commands:

- $ docker image pull --platform linux/arm64 <image>
- $ docker run --platform linux/arm64 --rm -d --entrypoint sleep <image> 3600
- $ docker container cp <container ID>:/bin/pcidevices ./pcidevices
- $ file pcidevices
      pcidevices: ELF 64-bit LSB executable, x86-64, version 1 (SYSV), statically linked, stripped 

Thanks.

tidy up template

tidy up template
Copy link
Contributor

@Yu-Jack Yu-Jack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks.

Copy link
Member

@WebberHuang1118 WebberHuang1118 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks.

@ibrokethecloud ibrokethecloud merged commit 628bf62 into harvester:master Apr 24, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants