Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump: kubevirt to v1.1.1 and harvester to v1.3.0 #76

Merged
merged 1 commit into from
May 20, 2024

Conversation

Yu-Jack
Copy link
Contributor

@Yu-Jack Yu-Jack commented May 3, 2024

IMPORTANT: Please do not create a Pull Request without creating an issue first.

Problem:
Cause USB Passthrough need kubevirt v1.1.1, so need to bump it.

Solution:
Bump kubevirt and harvester. If we don't bump harvester, it will have sigs.k8s.io/controller-runtime/pkg/envtest/printer package not found error.

Related Issue:
harvester/harvester#1710
harvester/harvester#5746

Test plan:

Test image jk82421/pcidevices:v0.3.2.7

  • Test pcidevice passthrough - Test on my laptop with usb controller
  • Test vgpu passthrough - Test on lab. Then run lshw -C display, it shows the vgpu in the vm.

@Yu-Jack Yu-Jack self-assigned this May 3, 2024
Signed-off-by: Jack Yu <jack.yu@suse.com>
@Yu-Jack Yu-Jack marked this pull request as ready for review May 3, 2024 08:55
@Yu-Jack Yu-Jack changed the title bump: kubevirt to v1.1.1 bump: kubevirt to v1.1.1 and harvester to v1.3.0 May 3, 2024
Copy link
Collaborator

@ibrokethecloud ibrokethecloud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. thanks.

@ibrokethecloud ibrokethecloud merged commit cf17440 into harvester:master May 20, 2024
5 checks passed
@Yu-Jack Yu-Jack deleted the feat-1710-bump-kubevirt branch May 24, 2024 02:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants