Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: remove dist directory #31

Merged
merged 1 commit into from
Jul 17, 2024
Merged

ci: remove dist directory #31

merged 1 commit into from
Jul 17, 2024

Conversation

starbops
Copy link
Member

IMPORTANT: Please do not create a Pull Request without creating an issue first.

Problem:

In the Run dapper step of the newly introduced GitHub Actions workflow, there's an obscure error message that we didn't catch during PR #30 review:

time="2024-04-25T14:09:33Z" level=info msg="docker cp /go/src/github.com/harvester/vm-dhcp-controller/bin ."
time="2024-04-25T14:09:34Z" level=info msg="docker cp /go/src/github.com/harvester/vm-dhcp-controller/dist ."
Error response from daemon: Could not find the file /go/src/github.com/harvester/vm-dhcp-controller/dist in container vm-dhcp-controller-CapmMhO
time="2024-04-25T14:09:34Z" level=info msg="docker cp /go/src/github.com/harvester/vm-dhcp-controller/chart/crds chart"

We've removed the copy of binaries to the dist/ directory but didn't remove it from Dockerfile.dapper. So Dapper will still try to copy the built artifacts from that directory, which no longer exist, thus causing the error.

Solution:

Remove the dist directory from the list of DAPPER_OUTPUT environment variable in the Dockerfile.dapper file.

Related Issue:

Test plan:

Check the GitHub Actions output.

Also, bump setup-go action to v5.

Signed-off-by: Zespre Chang <zespre.chang@suse.com>
Copy link
Contributor

@Yu-Jack Yu-Jack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@starbops starbops merged commit 9fac50f into harvester:main Jul 17, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants