vm-import-controller enhancements #31
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…xport from source fails to stop rather than keep trying added more debug info close lease earlier stage vmware migration improvements improve openstack migration to check uefi/tpm/secureboot from associated image improve firmware lookup for openstack, and add ability to specify custom storage classes fix storage class caching issue drop need for sync fix imports
ibrokethecloud
force-pushed
the
limit-retries
branch
from
f626926
to
9e33784
Compare
fixed dapper builds and default bus type on vmware
ibrokethecloud
force-pushed
the
limit-retries
branch
from
38e734f
to
fdf9e14
Compare
Yu-Jack
reviewed
Jul 9, 2024
starbops
approved these changes
Aug 1, 2024
There was a problem hiding this comment.
Generally LGTM, just need you to help fix some typos. Also, we need to update the chart as the controller complains about it cannot list & watch StorageClass:
W0801 07:41:36.080694 1 reflector.go:424] pkg/mod/k8s.io/client-go@v0.26.4/tools/cache/reflector.go:169: failed to list *v1.StorageClass: storageclasses.storage.k8s.io is forbidden: User "system:serviceaccount:harvester-system:harvester-vm-import-controller" cannot list resource "storageclasses" in API group "storage.k8s.io" at the cluster scope
E0801 07:41:36.080716 1 reflector.go:140] pkg/mod/k8s.io/client-go@v0.26.4/tools/cache/reflector.go:169: Failed to watch *v1.StorageClass: failed to list *v1.StorageClass: storageclasses.storage.k8s.io is forbidden: User "system:serviceaccount:harvester-system:harvester-vm-import-controller" cannot list resource "storageclasses" in API group "storage.k8s.io" at the cluster scope
Thank you!
fix up typos
ibrokethecloud
force-pushed
the
limit-retries
branch
from
4600028
to
1fea3d1
Compare
|
@Mergifyio backport v1.3 |
1 similar comment
|
@Mergifyio backport v1.3 |
✅ Backports have been created
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR introduces changes to vm import controller to improve the following:
IMPORTANT: Please do not create a Pull Request without creating an issue first.
Problem:
Solution:
Related Issue:
harvester/harvester#5758
Test plan: