Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(HIP-869): Dynamic Address Book - Stage 1 - HAPI Endpoints #1892

Merged
merged 11 commits into from
Aug 22, 2024
Merged

Conversation

thenswan
Copy link
Contributor

@thenswan thenswan commented Jul 12, 2024

Description:
This PR implements HIP-869: Dynamic Address Book - Stage 1 - HAPI Endpoints.

Related issue(s):
Closes #1851 #1852 #1853 #1854 #1855

Notes for reviewer:
Added some useful SDK methods:

  • addXXXEndpoint() - to add only one Endpoint
  • NodeUpdateTransaction.clearDescription() as Java SDK has similar methods in other transaction where there is a memo field

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.) <--TBD

Signed-off-by: Nikita Lebedev <nikita.lebedev@limechain.tech>
Signed-off-by: Nikita Lebedev <nikita.lebedev@limechain.tech>
Signed-off-by: Nikita Lebedev <nikita.lebedev@limechain.tech>
Signed-off-by: Nikita Lebedev <nikita.lebedev@limechain.tech>
Signed-off-by: Nikita Lebedev <nikita.lebedev@limechain.tech>
Signed-off-by: Nikita Lebedev <nikita.lebedev@limechain.tech>
Signed-off-by: Nikita Lebedev <nikita.lebedev@limechain.tech>
Copy link

sonarcloud bot commented Jul 15, 2024

Signed-off-by: Ivan Ivanov <ivanivanov.ii726@gmail.com>
Signed-off-by: Ivan Ivanov <ivanivanov.ii726@gmail.com>
@0xivanov 0xivanov marked this pull request as ready for review August 22, 2024 08:49
@0xivanov 0xivanov requested review from a team as code owners August 22, 2024 08:49
@0xivanov 0xivanov self-assigned this Aug 22, 2024
@0xivanov 0xivanov added the enhancement New feature or request label Aug 22, 2024
Copy link

sonarcloud bot commented Aug 22, 2024

Copy link
Contributor

@agadzhalov agadzhalov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, ty @thenswan and @0xivanov

@0xivanov 0xivanov merged commit 0adfe0e into main Aug 22, 2024
9 checks passed
@0xivanov 0xivanov deleted the hip-869 branch August 22, 2024 09:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
3 participants