Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(HIP-904) - TokenAirdropTransaction #1966

Merged
merged 11 commits into from
Sep 9, 2024
Merged

feat(HIP-904) - TokenAirdropTransaction #1966

merged 11 commits into from
Sep 9, 2024

Conversation

0xivanov
Copy link
Contributor

@0xivanov 0xivanov commented Aug 26, 2024 •
edited
Loading

Description:

  • Implements TokenAirdropTransaction and it's unit/e2e tests
  • Adds PendingAirdropId to the TransactionRecord

Related issue(s):

Fixes #1955 , #1953 , #1952

Notes for reviewer:

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

@0xivanov
feat: initial TokenAirdropTransaction impl
d05741d 
Signed-off-by: Ivan Ivanov <ivanivanov.ii726@gmail.com>
@0xivanov
test: add unit tests
dc58ca9 
Signed-off-by: Ivan Ivanov <ivanivanov.ii726@gmail.com>
@0xivanov
chore: formatting and docs
b2a1772 
Signed-off-by: Ivan Ivanov <ivanivanov.ii726@gmail.com>
@0xivanov 0xivanov added the enhancement New feature or request label Aug 26, 2024
@0xivanov 0xivanov self-assigned this Aug 26, 2024
@0xivanov
chore: copyrights
2f5e462 
Signed-off-by: Ivan Ivanov <ivanivanov.ii726@gmail.com>
@0xivanov
chore: extract common transfer logic
98b3eae 
Signed-off-by: Ivan Ivanov <ivanivanov.ii726@gmail.com>
@0xivanov
fix: tests
26a0405 
Signed-off-by: Ivan Ivanov <ivanivanov.ii726@gmail.com>
@0xivanov 0xivanov marked this pull request as ready for review August 28, 2024 07:48
@0xivanov 0xivanov requested review from a team as code owners August 28, 2024 07:48
@0xivanov
test: add e2e tests
7fbe0ae 
Signed-off-by: Ivan Ivanov <ivanivanov.ii726@gmail.com>
@0xivanov
chore: refactor
d49537b 
Signed-off-by: Ivan Ivanov <ivanivanov.ii726@gmail.com>
@0xivanov
chore: close testEnv
681e99b 
Signed-off-by: Ivan Ivanov <ivanivanov.ii726@gmail.com>
@0xivanov
chore: fix tests
7b7b137 
Signed-off-by: Ivan Ivanov <ivanivanov.ii726@gmail.com>
This was linked to issues Sep 3, 2024
Add HIP-904: PendingAirdropId #1952
Closed
Add HIP-904: PendingAirdropRecord #1953
Closed
@0xivanov
chore: refactoring
cc69f0b 
Signed-off-by: Ivan Ivanov <ivanivanov.ii726@gmail.com>
@0xivanov 0xivanov requested a review from a team as a code owner September 5, 2024 11:18
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Sep 5, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

agadzhalov
agadzhalov approved these changes Sep 9, 2024
View reviewed changes
Copy link
Contributor

@agadzhalov agadzhalov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great work @0xivanov, LGTM 🚀

@0xivanov 0xivanov merged commit fdd2bb8 into main Sep 9, 2024
12 checks passed
@0xivanov 0xivanov deleted the HIP-904-token-airdrop branch September 9, 2024 11:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@agadzhalov agadzhalov agadzhalov approved these changes

@rwalworth rwalworth Awaiting requested review from rwalworth rwalworth was automatically assigned from hashgraph/hedera-sdk

@ivaylonikolov7 ivaylonikolov7 Awaiting requested review from ivaylonikolov7

Assignees

@0xivanov 0xivanov

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add HIP-904: TokenAirdropTransaction Add HIP-904: PendingAirdropRecord Add HIP-904: PendingAirdropId
2 participants
@0xivanov @agadzhalov